perf: Avoid event serialization roundtrip #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
force-pushed
the
wip-SerializedEvent-patriknw
branch
from
433fb09
to
3c85cbd
Compare
patriknw
force-pushed
the
wip-SerializedEvent-patriknw
branch
2 times, most recently
from
cdd1fbe
to
ec33272
Compare
* journal handles write of SerializedEvent without additional serialization * SerializedEvent may be published (it can be serialized) and must be deserialized on receiving side
patriknw
force-pushed
the
wip-SerializedEvent-patriknw
branch
from
ec33272
to
167afc2
Compare
|
I have reduced this to only handle writes of SerializedEvent |
patriknw
commented
Sep 5, 2023
| @@ -10,7 +10,7 @@ object Dependencies { | |||
| val Scala3 = "3.2.2" | |||
| val Scala2Versions = Seq(Scala213, Scala212) | |||
| val ScalaVersions = Dependencies.Scala2Versions :+ Dependencies.Scala3 | |||
| val AkkaVersion = System.getProperty("override.akka.version", "2.8.3") | |||
| val AkkaVersion = System.getProperty("override.akka.version", "2.9.0-M1") | |||
There was a problem hiding this comment.
@johanandren I have updated to Akka 2.9.0-M1. Can you take a final look?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See akka/akka#32068 and akka/akka-projection#959