fix: Overload issue in ByteStringBuilder #32272 (#32274)

akka · Jan 2, 2024 · df01bd4 · df01bd4
1 parent dd86442
commit df01bd4
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/akka-actor-tests/src/test/scala/akka/util/ByteStringSpec.scala b/akka-actor-tests/src/test/scala/akka/util/ByteStringSpec.scala
@@ -1407,5 +1407,12 @@ class ByteStringSpec extends AnyWordSpec with Matchers with Checkers {
         }
       }
     }
+
+    // overloading issue #32272
+    "support adding arbitrary sequences of bytes" in {
+      val builder = new ByteStringBuilder()
+      builder ++= Seq[Byte](1, 2, 3)
+      builder.result() shouldEqual ByteString(1, 2, 3)
+    }
   }
 }
diff --git a/akka-actor/src/main/scala-2.13/akka/util/ByteString.scala b/akka-actor/src/main/scala-2.13/akka/util/ByteString.scala
@@ -1184,7 +1184,7 @@ final class ByteStringBuilder extends Builder[Byte, ByteString] {
           _length += seq.length
         }
       case _ =>
-        super.++=(xs)
+        super.addAll(xs)
     }
     this
   }

diff --git a/akka-actor/src/main/scala-3/akka/util/ByteString.scala b/akka-actor/src/main/scala-3/akka/util/ByteString.scala
@@ -1184,7 +1184,7 @@ final class ByteStringBuilder extends Builder[Byte, ByteString] {
           _length += seq.length
         }
       case _ =>
-        super.++=(xs)
+        super.addAll(xs)
     }
     this
   }