Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: logback 1.2.13 #32246

Merged
merged 1 commit into from
Dec 6, 2023
Merged

bump: logback 1.2.13 #32246

merged 1 commit into from
Dec 6, 2023

Conversation

patriknw
Copy link
Member

@patriknw patriknw commented Dec 6, 2023

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/qos-ch/logback/tags
Might be worth going to the 1.4 line for the Akka 24.04 release since we dropped Java 8. https://github.com/qos-ch/logback#building-logback

LGTM.

@patriknw
Copy link
Member Author

patriknw commented Dec 6, 2023

We can revisit the logback choice when closer to that release, but then we have to consider the sl4j 2.0 trouble #31593

@johanandren johanandren merged commit 2e47c16 into main Dec 6, 2023
5 checks passed
@johanandren johanandren deleted the wip-bump-logback-patriknw branch December 6, 2023 14:11
@johanandren johanandren added this to the 2.9.1 milestone Dec 6, 2023
He-Pin pushed a commit to He-Pin/akka that referenced this pull request Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants