Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set replication factor for offsets topic #588

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

2m
Copy link
Contributor

@2m 2m commented Oct 3, 2018

One more stability improvement to the docker integration tests: setting offsets.topic.replication.factor broker configuration property to the number of total Kafka nodes in the cluster.

This builds on top of environment variable support in the sbt-docker-compose plugin: dariush-y/sbt-docker-compose#10

@2m 2m force-pushed the wip-offsets-repl-factor-2m branch from 820a14d to 0cc42c6 Compare October 3, 2018 21:41
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of parts that need to fit together.
LGTM.

@ennru ennru merged commit e6c225d into akka:master Oct 4, 2018
@ennru ennru added this to the 1.0-M1 milestone Oct 4, 2018
@2m 2m deleted the wip-offsets-repl-factor-2m branch October 4, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants