Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka 2.4.0-RC1 #971

Merged
merged 1 commit into from
Nov 26, 2019
Merged

Kafka 2.4.0-RC1 #971

merged 1 commit into from
Nov 26, 2019

Conversation

seglo
Copy link
Contributor

@seglo seglo commented Nov 14, 2019

Purpose

WIP, current binary is RC1

Update to Kafka client 2.4.0

Details

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the necessary changes are smaller than your earlier tries indicated!

build.sbt Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
tests/src/test/java/docs/javadsl/SerializationTest.java Outdated Show resolved Hide resolved
tests/src/test/scala/docs/scaladsl/SerializationSpec.scala Outdated Show resolved Hide resolved
@seglo seglo force-pushed the seglo/kafka-2.4.0 branch from 0e2ff90 to 2c0e3c4 Compare November 25, 2019 16:52
@seglo seglo marked this pull request as ready for review November 25, 2019 17:09
@seglo
Copy link
Contributor Author

seglo commented Nov 25, 2019

#983

@seglo seglo requested a review from ennru November 25, 2019 17:12
@seglo seglo force-pushed the seglo/kafka-2.4.0 branch from 2c0e3c4 to e3b7042 Compare November 25, 2019 20:08
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru added this to the 2.0.0 milestone Nov 26, 2019
@ennru ennru changed the title Kafka 2.4.0 Kafka 2.4.0-RC1 Nov 26, 2019
@ennru ennru merged commit ada44cd into akka:master Nov 26, 2019
@francisdb
Copy link

Pointing to "Apache Staging" at "https://repository.apache.org/content/groups/staging/" is dangerous as the artifacts in there have the final version tag but still go through a few iterations before they become final. (currently RC3)
This means that any local ivy/coursier caches might stick with this older incorrect versions.

@ennru
Copy link
Member

ennru commented Dec 11, 2019

Yes. Users have to add it themselves, though. We have a warning about it: https://doc.akka.io/docs/alpakka-kafka/2.0/release-notes/2.0.x.html#2-0-0-m2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants