AMQ: multiple hosts in AmqpDetailsConnectionProvider #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @EldarKZ16, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
ennru
reviewed
Jun 25, 2019
| @@ -203,6 +203,9 @@ object AmqpDetailsConnectionProvider { | |||
| def apply(host: String, port: Int): AmqpDetailsConnectionProvider = | |||
| new AmqpDetailsConnectionProvider(immutable.Seq(host -> port)) | |||
|
|
|||
| def apply(hostAndPorts: immutable.Seq[(String, Int)]): AmqpDetailsConnectionProvider = | |||
There was a problem hiding this comment.
Please add it to the Java API with j.u.Collection<akka.japi.Pair<String, Integer>>, as well.
There was a problem hiding this comment.
You need to add some conversion logic...
There was a problem hiding this comment.
Oh, I forgot, sorry about this. Fixed.
There was a problem hiding this comment.
Oops, your change is adapting the wrong data.
There was a problem hiding this comment.
I'm Junior Backend developer :)
ennru
changed the title
|
Thank you! Keep the improvements coming. |
cheleb
pushed a commit
to cheleb/alpakka
that referenced
this pull request
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Create AmqpDetailsConnectionProvider with multiple hosts and ports
References
References #xxxx
Changes
Background Context