Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMQ: multiple hosts in AmqpDetailsConnectionProvider #1772

Merged
merged 4 commits into from
Jun 25, 2019
Merged

AMQ: multiple hosts in AmqpDetailsConnectionProvider #1772

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1e11f0
Add additional AmqpDetailsConnectionProvider apply method
EldarKZ16 Jun 24, 2019
2c1b60c
add AmqpDetailsConnectionProvider apply method for java api
EldarKZ16 Jun 25, 2019
93214bb
fix
EldarKZ16 Jun 25, 2019
ee29aa5
fix apply methods
EldarKZ16 Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions amqp/src/main/scala/akka/stream/alpakka/amqp/AmqpConnectionProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,11 +203,17 @@ object AmqpDetailsConnectionProvider {
def apply(host: String, port: Int): AmqpDetailsConnectionProvider =
new AmqpDetailsConnectionProvider(immutable.Seq(host -> port))

def apply(hostAndPorts: immutable.Seq[(String, Int)]): AmqpDetailsConnectionProvider =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it to the Java API with j.u.Collection<akka.japi.Pair<String, Integer>>, as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add some conversion logic...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot, sorry about this. Fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, your change is adapting the wrong data.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm Junior Backend developer :)

new AmqpDetailsConnectionProvider(hostAndPorts)

/**
* Java API
*/
def create(host: String, port: Int): AmqpDetailsConnectionProvider =
AmqpDetailsConnectionProvider(host, port)

def create(hostAndPorts: java.util.List[akka.japi.Pair[String, Int]]): AmqpDetailsConnectionProvider =
AmqpDetailsConnectionProvider(hostAndPorts.asScala.map(_.toScala).toIndexedSeq)
}

final class AmqpCredentials private (val username: String, val password: String) {
Expand Down