Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle XML exceptions #3003

Merged
merged 6 commits into from
Aug 27, 2023
Merged

Handle XML exceptions #3003

merged 6 commits into from
Aug 27, 2023

Conversation

JustinPihony
Copy link
Contributor

This resolves #2532

Copy link
Member

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as is, but left a suggestion as well, you decide if it simplifies things.

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit 5012492 into main Aug 27, 2023
49 checks passed
@ennru ennru deleted the Issue2532 branch August 27, 2023 15:20
@sebastian-alfers sebastian-alfers added this to the 7.0.0 milestone Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants