Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTP: RemoteFileSettings classes inside or outside companion object? #395

Closed
raboof opened this issue Jul 12, 2017 · 2 comments
Closed

FTP: RemoteFileSettings classes inside or outside companion object? #395

raboof opened this issue Jul 12, 2017 · 2 comments
Labels
p:ftp
Milestone
0.11

Comments

@raboof
Copy link
Contributor

raboof commented Jul 12, 2017

Most subclasses of RemoteFileSettings are defined inside the RemoteFileSettings companion object, but SftpSettings are defined outside.

What do we prefer?
@juanjovazquez
Copy link

@raboof We should review the entire model looking for consistency. I didn't want to do it in the context of #373 in order to not face too many changes at once. Maybe we can deal with that after merging. WDYT?.

@raboof
Copy link
Contributor Author

raboof commented Jul 12, 2017

I agree we should treat this as a separate issue and not roll it into #373

@raboof raboof added the p:ftp label Jul 12, 2017
juanjovazquez pushed a commit to Tecsisa/alpakka that referenced this issue Jul 15, 2017
FTP Homogenize model (fixes akka#395)
92079a9
@juanjovazquez juanjovazquez mentioned this issue Jul 15, 2017
Merged
juanjovazquez pushed a commit to Tecsisa/alpakka that referenced this issue Jul 19, 2017
FTP Homogenize model (fixes akka#395)
0b4d38b
juanjovazquez pushed a commit to Tecsisa/alpakka that referenced this issue Jul 19, 2017
FTP Homogenize model (fixes akka#395)
612b022
raboof pushed a commit that referenced this issue Jul 21, 2017
@raboof
FTP Homogenize model (fixes #395) (#407)
95eb459
@raboof raboof added this to the 0.11 milestone Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:ftp
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
2 participants
@raboof @juanjovazquez