Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align local date in s3 stream signing key to UTC #1678

Merged
merged 1 commit into from
May 6, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions s3/src/main/scala/akka/stream/alpakka/s3/impl/S3Stream.scala
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

package akka.stream.alpakka.s3.impl

import java.time.{Instant, LocalDate}
import java.time.{Instant, LocalDate, ZoneOffset}

import akka.actor.ActorSystem
import akka.annotation.InternalApi
Expand Down Expand Up @@ -91,7 +91,7 @@ import akka.util.ByteString
// def because tokens can expire
def signingKey(implicit settings: S3Settings) = SigningKey(
settings.credentialsProvider,
CredentialScope(LocalDate.now(), settings.s3RegionProvider.getRegion, "s3")
CredentialScope(LocalDate.now(ZoneOffset.UTC), settings.s3RegionProvider.getRegion, "s3")
)

def download(
Expand Down