Issue 1786 - 'messageId' and 'publishTime' should not be published #1795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r required when creating PubSubMessage for publishing.
2m
reviewed
Jul 1, 2019
google-cloud-pub-sub/src/main/scala/akka/stream/alpakka/googlecloud/pubsub/model.scala
Outdated
Show resolved
Hide resolved
2m
approved these changes
Jul 1, 2019
|
Thank you for your first contribution! Keep them coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nor should be 'messageId' be required when creating PubSubMessage for publishing.
Purpose
Improve Scala and Java API - don't require redundant parameter
Improve compliance with Google Cloud PubSub HTTP API - don't send fields that shouldn't be sent.
References
References #1786
Changes
Background Context
I wanted to create separate case class for publishing PubSub message but I went in a direction to not break code.
If for 1.1 we can break source and binary compatibility, I'd like to contribute other change.