Update to the latest Akka 2.6-M4 #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
dependency-change
patriknw
approved these changes
Jul 5, 2019
| @@ -43,5 +43,5 @@ private[mqtt] object QueueOfferState { | |||
| case (_, other) => | |||
| waitForQueueOfferCompleted(behavior, stash = stash :+ other) | |||
| } | |||
There was a problem hiding this comment.
not related to this change, but I wonder if that unstashing by sending to self is correct? it would be ok if the order of QueueOfferCompleted messages doesn't matter, otherwise another QueueOfferCompleted could already be in the mailbox and be processed by the behavior before the unstashed messages. Solution would be to use StashBuffer.
chbatey
approved these changes
Jul 5, 2019
longshorej
added a commit
to longshorej/alpakka
that referenced
this pull request
Jul 17, 2019
2m
added a commit
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Keeps nightlies in sync with the latest Akka release.