Added possibility configure SFTP connection using private key #197. #202
Conversation
argast
commented
Feb 23, 2017
argast
commented
- Added SftpIdentity case class to allow configuring private/public key,
- Added Java API methods to configure SftpIdentity from Java
- Added Scala spec and Java test that should fail password based authentication and revert to private key one,
- Added docs paragraph to describe this option.
| @@ -97,7 +97,8 @@ object RemoteFileSettings { | |||
| host: InetAddress, | |||
| port: Int = DefaultSftpPort, | |||
| credentials: FtpCredentials = AnonFtpCredentials, | |||
| strictHostKeyChecking: Boolean = true | |||
| strictHostKeyChecking: Boolean = true, | |||
There was a problem hiding this comment.
Should we deal with the case of strict host key checking in the context of this issue?. On that case, we probably should let specify a known_hosts custom file.
There was a problem hiding this comment.
Yes, that would be useful as well. I will add it to SftpSettings then.
There was a problem hiding this comment.
Some additional testing covering this would be welcome :)
| Some(SftpIdentity(name, privateKey, Some(password))) | ||
|
|
||
| /** Java API */ | ||
| def createSftpIdentity(name: String, |
There was a problem hiding this comment.
I think the format on signatures is not following the previous ones along the project. It's just a nitpick but important in the long term.
There was a problem hiding this comment.
Do you mean to use withFoo methods similar to amqp model?
There was a problem hiding this comment.
Nop, more silly than that. Just enter a carriage return after the parentheses so that scalafmt line up left on the next line.
There was a problem hiding this comment.
Actually I like the way withFoo works, it's a nicer way to handle Option in Java so I think I will migrate java API methods to withFoo way.
| case class SftpIdentity(name: String, | ||
| privateKey: Array[Byte], | ||
| password: Option[Array[Byte]] = None, | ||
| publicKey: Option[Array[Byte]] = None) |
There was a problem hiding this comment.
I wonder if it would be interesting to offer variants of the identity specification based on files on the classpath in addition to these Array[Byte].
There was a problem hiding this comment.
It's a good idea, I will add additional case class with possibility to specify location of key files and passphrase.
- Added SftpIdentity case class to allow configuring private/public key, - Added option to configure known_hosts file and test to check its usage. - Added spec that should fail password based authentication and revert to private key one, - Added docs paragraph to describe this option.
|
Thanks for the review. I rebased the code. |
|
Great. Thanks! |
