Directory sources #274
Directory sources #274
Conversation
| public final class Directory { | ||
|
|
||
| /** | ||
| * List all files in the given directory |
| StreamConverters.fromJavaStream(() => Files.walk(directory)) | ||
| } | ||
|
|
||
| private def allFilesFilter = new BiPredicate[Path, BasicFileAttributes] { |
| * Recursively list files in the given directory and its subdirectories. Listing is done | ||
| * depth first. | ||
| */ | ||
| def walk(directory: Path): Source[Path, NotUsed] = { |
There was a problem hiding this comment.
I think it would be good to expose the overloads too:
https://docs.oracle.com/javase/8/docs/api/java/nio/file/Files.html#walk-java.nio.file.Path-int-java.nio.file.FileVisitOption...-
the visit options and depth seem very useful when someone would be using this API
There was a problem hiding this comment.
I started out with that, but then thought that it is so simple to create it yourself, so maybe more specific needs can be met by just looking at the sources of this and copying that single line of code...
There was a problem hiding this comment.
I think with alpakka we're targeting an "works out of the box" and "I would not look at the sources" use cases/people, so I'd really add those parameters IMHO
There was a problem hiding this comment.
This was rather from the not covering every conceivable use case under the sun, just the "normal" ones point of view, especially the filter which could be achieved by composition (with a bit of alloc overhead, but hey this is disk io we are talking about here).
Could you come up with a common use case for depths other than 0, which is covered by ls and all the depth (find ./) which is covered by this?
There was a problem hiding this comment.
Depth is pretty important to protect from entering infinite loops with symlinks to an upper directory if I remember correctly how these APIs work?
There was a problem hiding this comment.
Alright, I'll add it. Skipping filter though, as that can be achieved with composition.
| @@ -13,7 +13,7 @@ import akka.stream.{ActorMaterializer, Materializer} | |||
|
|
|||
| import scala.concurrent.duration._ | |||
|
|
|||
| object FileTailSourceSpec extends { | |||
| def walk(directory: Path): Source[Path, NotUsed] = { | ||
| def walk(directory: Path, | ||
| maxDepth: Option[Int] = None, | ||
| fileVisitOptions: immutable.Seq[FileVisitOption] = Nil): Source[Path, NotUsed] = { |
Refs #272
Adds
Directory.lsandDirectory.walkto stream file paths from the filesystem.