Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File: Add zip compression level #2980

Merged
merged 3 commits into from
Jun 9, 2023
Merged

File: Add zip compression level #2980

merged 3 commits into from
Jun 9, 2023

Conversation

gael-ft
Copy link
Contributor

@gael-ft gael-ft commented May 23, 2023

Fixes #2766

@gael-ft
Add deflate compression level in zip flow akka#2766
ed79baa
@gael-ft
Avoid unnecessary ByteString operation in zip flow
b38da06 
* Elements pushed to zip flow might be of any size. Decoding them completly using utf8 just to check a few bytes at the beginning can be a big loss.
ennru
ennru approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking this on!
LGTM.

@ennru ennru merged commit 6494e86 into akka:main Jun 9, 2023
@ennru ennru mentioned this pull request Jun 9, 2023
Closed
aludwiko added a commit that referenced this pull request Jul 27, 2023
@aludwiko
Revert "File: Add zip compression level (#2980)"
fcdfb40 
This reverts commit 6494e86.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
p:file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Zip Archive Compression Level
2 participants
@gael-ft @ennru