Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: solr-solrj, solr-test-framework 9.5.0 (was 8.11.3) #3126

Closed

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates

from 8.11.3 to 9.5.0

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.apache.solr" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.solr" }
}]
labels: library-update, early-semver-major, semver-spec-major, commit-count:1

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Feb 25, 2024
@ennru
Copy link
Member

ennru commented Mar 28, 2024

The upgrade requires code changes

[error] /home/runner/work/alpakka/alpakka/solr/src/main/scala/akka/stream/alpakka/solr/impl/SolrFlowStage.scala:110:24: value getIdField is not a member of org.apache.solr.client.solrj.impl.CloudSolrClient
[error]             Option(csc.getIdField)
[error]                        ^
[error] one error found

In tests

[error] /Users/enno/dev/alpakka/solr/src/test/scala/docs/scaladsl/SolrSpec.scala:20:8: object JettyConfig is not a member of package org.apache.solr.client.solrj.embedded
[error] import org.apache.solr.client.solrj.embedded.JettyConfig
[error]        ^
[error] /Users/enno/dev/alpakka/solr/src/test/scala/docs/scaladsl/SolrSpec.scala:769:7: not found: value JettyConfig
[error]       JettyConfig.builder.setContext("/solr").build,
[error]       ^
[error] /Users/enno/dev/alpakka/solr/src/test/scala/docs/scaladsl/SolrSpec.scala:774:8: value uploadConfig is not a member of org.apache.solr.client.solrj.impl.ZkClientClusterStateProvider
[error] possible cause: maybe a semicolon is missing before `value uploadConfig`?
[error]       .uploadConfig(confDir.toPath, "conf")
[error]        ^
[error] /Users/enno/dev/alpakka/solr/src/test/scala/docs/scaladsl/SolrSpec.scala:775:16: value setIdField is not a member of org.apache.solr.client.solrj.impl.CloudSolrClient
[error]     solrClient.setIdField("router")
[error]                ^
[error] /Users/enno/dev/alpakka/solr/src/test/scala/docs/scaladsl/SolrSpec.scala:777:28: value getZkStateReader is not a member of org.apache.solr.client.solrj.impl.CloudSolrClient
[error]     assertTrue(!solrClient.getZkStateReader.getClusterState.getLiveNodes.isEmpty)
[error]                            ^

Refs

@ennru ennru added the p:solr label Mar 28, 2024
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code needs to be updated along this version bump.

@scala-steward
Copy link
Contributor Author

Superseded by #3187.

@scala-steward scala-steward deleted the update/solr-solrj-9.5.0 branch May 9, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:solr
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants