Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump(geode test): log4j-to-slf4j 2.23.1 (was 2.17.2) #3144

Closed

Conversation

scala-steward
Copy link
Contributor

About this PR

📦 Updates org.apache.logging.log4j:log4j-to-slf4j from 2.17.2 to 2.23.1

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

🔍 Files still referring to the old version number

The following files still refer to the old version number (2.17.2).
You might want to review and update them manually.

project/Dependencies.scala
⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.apache.logging.log4j", artifactId = "log4j-to-slf4j" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.apache.logging.log4j", artifactId = "log4j-to-slf4j" }
}]
labels: test-library-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

@probot-autolabeler probot-autolabeler bot added the dependency-change For PRs changing the version of a dependency. label Mar 12, 2024
@ennru ennru changed the title bump: log4j-to-slf4j 2.23.1 (was 2.17.2) bump(geode test): log4j-to-slf4j 2.23.1 (was 2.17.2) Mar 28, 2024
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru self-requested a review March 28, 2024 09:26
@ennru
Copy link
Member

ennru commented Mar 28, 2024

The logging setup is broken for Geode.

[info]   java.lang.IllegalArgumentException: Requires Logback logger for [], it was a [org.slf4j.helpers.NOPLogger]
[info]   at akka.stream.alpakka.testkit.LogbackUtil$.getLogbackLoggerInternal(LogbackUtil.scala:37)

@ennru ennru added the p:geode label Mar 28, 2024
@ennru
Copy link
Member

ennru commented Apr 4, 2024

This pulls slf4j 2

[info]   +-org.apache.logging.log4j:log4j-to-slf4j:2.23.1
[info]     +-org.apache.logging.log4j:log4j-api:2.23.1
[info]     +-org.slf4j:slf4j-api:2.0.9

Refs

@ennru ennru closed this Apr 4, 2024
@scala-steward scala-steward deleted the update/log4j-to-slf4j-2.23.1 branch April 8, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency-change For PRs changing the version of a dependency. p:geode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants