CSV: Emit all lines on completion #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @kciesielski described in akka#315 he encountered a bug which sometimes swallowed CSV lines. The issue occurs on stream completion when more than on CSV line is not parsed yet and the last line has no line ending. I haven't been able to re-create the issue in a proper test case as it is connected to stream execution timings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @kciesielski described in #315 he encountered a bug which sometimes swallowed CSV
lines.
The issue occurs on stream completion when more than on CSV line is not parsed yet and the
last line has no line ending.
I haven't been able to re-create the issue in a proper test case as it is connected to
stream execution timings.