Add ClusterClientDiscovery Hosting extension support #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Directory.Build.props
Aaronontheweb
requested changes
Jul 26, 2024
Aaronontheweb
requested changes
Jul 29, 2024
| /// <see cref="ClusterClientDiscovery"/> to work, you <b>will need</b> to set | ||
| /// <c>DiscoveryOptions.IsDefaultPlugin</c> to <c>false</c> | ||
| /// </summary> | ||
| public IHoconOption DiscoveryOptions { get; set; } = null!; |
There was a problem hiding this comment.
Per our call, use IDiscoveryOption or whatever here
| private void Validate() | ||
| { | ||
| var type = DiscoveryOptions.GetType().Name; | ||
| if(!(type.Contains("ConfigServiceDiscoveryOptions") |
There was a problem hiding this comment.
Rather than do stringly-typed stuff, use the IDiscoveryOption type we proposed on the call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ClusterClientDiscoveryOptionsclassClusterClientextensions methodsWithClusterClientDiscoverythat allows users to useClusterClientDiscovery