[Discovery.KubernetesApi] add option to query pods in all namespaces #2421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
approved these changes
Mar 27, 2024
| # Enable to query pods in all namespaces | ||
| # | ||
| # If this is set to true, the pod-namespace configuration is ignored. | ||
| all-namespaces = true |
|
|
||
| var cts = new CancellationTokenSource(resolveTimeout); | ||
| V1PodList podList; | ||
| try | ||
| { | ||
| #if !NET6_0_OR_GREATER |
There was a problem hiding this comment.
So we moved the ifdefs down into these individual methods - got it
| @@ -89,27 +89,17 @@ public override async Task<Resolved> Lookup(Lookup lookup, TimeSpan resolveTimeo | |||
| var labelSelector = _settings.PodLabelSelector(lookup.ServiceName); | |||
|
|
|||
| if(_log.IsInfoEnabled) | |||
| _log.Info("Querying for pods with label selector: [{0}]. Namespace: [{1}]. Port: [{2}]", | |||
| labelSelector, PodNamespace, lookup.PortName); | |||
| _log.Info("Querying for pods with label selector: [{0}]. Namespace: [{1}]. AllNamespaces: [{2}]. Port: [{3}]", | |||
| @@ -177,7 +167,45 @@ public override async Task<Resolved> Lookup(Lookup lookup, TimeSpan resolveTimeo | |||
|
|
|||
| return new Resolved(serviceName: lookup.ServiceName, addresses: addresses); | |||
| } | |||
|
|
|||
| private async Task<V1PodList> ListNamespacedPod(string labelSelector, CancellationTokenSource cts) | |||
There was a problem hiding this comment.
LGTM - basically what we had before
|
|
||
| private async Task<V1PodList> ListPodForAllNamespaces(string labelSelector, CancellationTokenSource cts) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new option to query K8s Pods in all namespaces instead of querying in a specific namespace. It still supports to filter by
podSelectorChecklist
For significant changes, please ensure that the following have been completed (delete if not relevant):