Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor IHoconOptions to IDiscoveryOptions #2678

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Refactor IHoconOptions to IDiscoveryOptions #2678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ Update all AWSSDK versions</PackageReleaseNotes>
<TestSdkVersion>17.10.0</TestSdkVersion>
<WireMockVersion>1.5.60</WireMockVersion>

<AkkaVersion>1.5.26</AkkaVersion>
<AkkaHostingVersion>1.5.25</AkkaHostingVersion>
<AkkaVersion>1.5.27.1</AkkaVersion>
<AkkaHostingVersion>1.5.27</AkkaHostingVersion>
<PbmVersion>1.4.3</PbmVersion>

<KubernetesClientVersionNetStandard>4.0.26</KubernetesClientVersionNetStandard>
Expand Down
2 changes: 1 addition & 1 deletion src/discovery/aws/Akka.Discovery.AwsApi/Ec2/Ec2ServiceDiscoveryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

namespace Akka.Discovery.AwsApi.Ec2;

public class Ec2ServiceDiscoveryOptions: IHoconOption
public class Ec2ServiceDiscoveryOptions: IDiscoveryOptions
{
public string ConfigPath { get; set; } = AwsEc2Discovery.DefaultPath;
internal static string FullPath(string path) => $"akka.discovery.{path}";
Expand Down
2 changes: 1 addition & 1 deletion src/discovery/aws/Akka.Discovery.AwsApi/Ecs/EcsServiceDiscoveryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

namespace Akka.Discovery.AwsApi.Ecs;

public class EcsServiceDiscoveryOptions: IHoconOption
public class EcsServiceDiscoveryOptions: IDiscoveryOptions
{
public string ConfigPath { get; } = AwsEcsDiscovery.DefaultPath;
internal static string FullPath(string path) => $"akka.discovery.{path}";
Expand Down
2 changes: 1 addition & 1 deletion src/discovery/azure/Akka.Discovery.Azure/AkkaDiscoveryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

namespace Akka.Discovery.Azure;

public class AkkaDiscoveryOptions: IHoconOption
public class AkkaDiscoveryOptions: IDiscoveryOptions
{

public string ConfigPath { get; set; } = "azure";
Expand Down
2 changes: 1 addition & 1 deletion src/discovery/kubernetes/Akka.Discovery.KubernetesApi/KubernetesDiscoveryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

namespace Akka.Discovery.KubernetesApi;

public class KubernetesDiscoveryOptions: IHoconOption
public class KubernetesDiscoveryOptions: IDiscoveryOptions
{
public string ConfigPath { get; set; } = KubernetesApiServiceDiscovery.DefaultPath;
public Type Class { get; } = typeof(KubernetesApiServiceDiscovery);
Expand Down
2 changes: 1 addition & 1 deletion src/management/Akka.Management/Discovery/Config/ConfigServiceDiscoveryOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
// ReSharper disable once CheckNamespace
namespace Akka.Discovery.Config.Hosting;

public class ConfigServiceDiscoveryOptions: IHoconOption
public class ConfigServiceDiscoveryOptions: IDiscoveryOptions
{
internal const string DefaultPath = "config";
internal const string DefaultConfigPath = "akka.discovery." + DefaultPath;
Expand Down