NetStandard2.0 and NetCoreApp3.0 supports added #119
Conversation
…jects by removing static keyword from ExceptionTypeInfo and setting it in the constructor
* netcore3.0 support added
| var className = stream.ReadString(session); | ||
| var message = stream.ReadString(session); | ||
| var remoteStackTraceString = stream.ReadString(session); | ||
| var stackTraceString = stream.ReadString(session); | ||
| var innerException = stream.ReadObject(session); | ||
|
|
||
| _className.SetValue(exception,className); | ||
| #if NETSTANDARD20 | ||
| if (_className != null) |
There was a problem hiding this comment.
I guess this is an equivalent of _className?.SetValue(exception, className).
|
|
||
| exceptionSerializer.Initialize((stream, session) => | ||
| { | ||
| var exception = createInstance(type); | ||
| var exception = exceptionObject; |
There was a problem hiding this comment.
These two are not equivalent. createInstance(type) will return a new object on every deserializer call, while exceptionObject is an exception itself, so that the same instance will be captured and passed over and over. While this may not be obvious from simple unit tests, I'm not sure if this won't cause any troubles when called many times and from mutliple threads.
Do we have any way to prove that this change won't fail the running system?
There was a problem hiding this comment.
To be honest I did not test that scenario but you have a point. Therefore, I reverted it back to Func. Please see my updated pull request.
…rder to prevent runtime exceptions
There was a problem hiding this comment.
It looks ok for me. The change to keep an eye on is a .NET standard upgrade v1.6 → v2.0. Waiting for @Aaronontheweb
|
PR validation fails because our build tooling still uses the dotnet core 2.2 runtime. You can update your PR probably by just changing which dotnetcore runtime we download in the tooling. For an example check this out: https://github.com/petabridge/Petabridge.App.Web |
|
@Horusiath @Aaronontheweb @Danthar I have updated my PR. Validation should work well now. Can you please check? |
ref #118 #115 #111
Dotnet core 3.0 projects are being crashed while getting and setting _className in ExceptionSerializerFactory. _className value is always null but gets an exception in netcoreapp3.0 projects.
Moreover, getUninitializedObjectDelegate does not work with netcoreapp3.0 as well. Luckily FormatterServices is supported in netstandard2.0. In order to use it, I added netstandard2.0 support.
Summary