Build system update #120
Merged
Build system update #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Danthar
commented
Oct 3, 2019
Danthar
commented
- Bumped hyperion core to net452
- Updated build scripts to latest version. This included nbench targets although its not used in the solution. Did this so we end up with the same scripts all around. Makes it easier to maintain since there is no need for different build descriptions for each repo.
- Note that signing targets are also in there, but they are disabled in the target itself
- Bumped hyperion core to net452 - Updated build scripts to latest version. This included nbench targets although its not used in the solution. Did this so we end up with the same scripts all around. Makes it easier to maintain since there is no need for different build descriptions for each repo. - Note that signing targets are also in there, but they are disabled in the target itself
Danthar
commented
Oct 3, 2019
| //-------------------------------------------------------------------------------- | ||
| Target "SignPackages" (fun _ -> | ||
| let canSign = hasBuildParam "SignClientSecret" && hasBuildParam "SignClientUser" | ||
| if(false) then |
There was a problem hiding this comment.
This is different then what i did in the serilog packages. Because in order to test i need to actually run the pipeline (eventually) and i wanted to be sure it does not sign / cause errors.
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.