Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDictionary<TKey, TValue> support #156

Merged
merged 2 commits into from
Feb 6, 2020

Conversation

IgorFedchenko
Copy link
Contributor

Close #99

@IgorFedchenko IgorFedchenko marked this pull request as ready for review February 6, 2020 11:46
@IgorFedchenko
Copy link
Contributor Author

@Aaronontheweb added IDictionary<TKey, TValue> support (fixed current implementation), but did not change existing code which requires serialized object to implement IDictionary too.

You can merge this PR - in that case I will create separate issue about this and will try to resolve it. Or, if we have time, I will work on this PR later today/tomorrow and remove this IDictionary requirement.

@Aaronontheweb
Copy link
Member

@IgorFedchenko we should definitely create another issue to remove the non-generic IDictionary requirement for this feature, since generic IDictionary<TKey, TValue> doesn't take a dependency on it.

@Aaronontheweb Aaronontheweb merged commit a66b88e into akkadotnet:dev Feb 6, 2020
@IgorFedchenko IgorFedchenko deleted the feature/genetic-dict branch February 6, 2020 18:55
@IgorFedchenko
Copy link
Contributor Author

Added issue: #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement support for IDictionary<TKey,TValue>
2 participants