Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IDictionary<T, V> serializer to not use IDictionary assumption #158

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Update IDictionary<T, V> serializer to not use IDictionary assumption #158

merged 2 commits into from
Feb 7, 2020

Conversation

IgorFedchenko
Copy link
Contributor

Close #157

Some fun with reflection, and now it works without requiring IDictionary to be implemented.

Aaronontheweb
Aaronontheweb approved these changes Feb 7, 2020
View reviewed changes
Copy link
Member

@Aaronontheweb Aaronontheweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aaronontheweb Aaronontheweb merged commit 01ed0c8 into akkadotnet:dev Feb 7, 2020
@IgorFedchenko IgorFedchenko deleted the fix/generic-dict-requirement branch February 7, 2020 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aaronontheweb Aaronontheweb Aaronontheweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove IDictionary requirement from IDictionary<TKey, TValue> serializer factory implementation
2 participants
@IgorFedchenko @Aaronontheweb