Fix settings constructor backward compatibility issue #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Apr 19, 2021
| @@ -72,7 +80,25 @@ public class SerializerOptions | |||
| internal readonly List<Func<string, string>> CrossFrameworkPackageNameOverrides = | |||
| DefaultPackageNameOverrides(); | |||
|
|
|||
| public SerializerOptions(bool versionTolerance = false, bool preserveObjectReferences = false, IEnumerable<Surrogate> surrogates = null, IEnumerable<ValueSerializerFactory> serializerFactories = null, IEnumerable<Type> knownTypes = null, bool ignoreISerializable = false, IEnumerable<Func<string, string>> packageNameOverrides = null) | |||
| [Obsolete] | |||
| public SerializerOptions( | |||
There was a problem hiding this comment.
This is the old constructor, added back in for backward compatibility issue.
New constructor broke backward compatibility because it was called using reflection and Activator class.
There was a problem hiding this comment.
IMHO, this is part of the problem with using optional parameters everywhere - very difficult to properly version the constructor when that happens. That's a design we inherited, but we might want to rethink that.
Aaronontheweb
requested changes
Apr 19, 2021
|
Will do |
| @@ -0,0 +1,30 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Probably need to have this reference common.props
This was referenced Apr 19, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #212