Cleanup type blacklist PR #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkatufus
commented
Aug 16, 2021
| @@ -23,7 +23,8 @@ public class SerializerOptions | |||
| serializerFactories: null, | |||
| knownTypes: null, | |||
| ignoreISerializable: false, | |||
| packageNameOverrides: null); | |||
| packageNameOverrides: null, | |||
| disallowUnsafeTypes: true); | |||
There was a problem hiding this comment.
Move disallow unsafe types flag to options
Arkatufus
commented
Aug 16, 2021
| private static bool IsValueType(this Type type) | ||
| => type.IsSubclassOf(typeof(ValueType)); | ||
|
|
||
| private static bool IsSubclassOf(this Type p, Type c) |
There was a problem hiding this comment.
Add missing type functions to netstandard 1.6, needed for the type blacklisting feature.
Arkatufus
commented
Aug 16, 2021
| @@ -398,6 +406,11 @@ public class T | |||
| /// </summary> | |||
| private static bool IsSimilarType(this Type thisType, Type type) | |||
| { | |||
| if (thisType == null && type == null) | |||
| return true; | |||
| if (thisType == null || type == null) | |||
There was a problem hiding this comment.
Null check for safety
Aaronontheweb
approved these changes
Aug 16, 2021
| public SerializerOptions(bool versionTolerance, bool preserveObjectReferences, System.Collections.Generic.IEnumerable<Hyperion.Surrogate> surrogates, System.Collections.Generic.IEnumerable<Hyperion.SerializerFactories.ValueSerializerFactory> serializerFactories, System.Collections.Generic.IEnumerable<System.Type> knownTypes, bool ignoreISerializable, System.Collections.Generic.IEnumerable<System.Func<string, string>> packageNameOverrides) { } | ||
| public SerializerOptions(bool versionTolerance, bool preserveObjectReferences, System.Collections.Generic.IEnumerable<Hyperion.Surrogate> surrogates, System.Collections.Generic.IEnumerable<Hyperion.SerializerFactories.ValueSerializerFactory> serializerFactories, System.Collections.Generic.IEnumerable<System.Type> knownTypes, bool ignoreISerializable, System.Collections.Generic.IEnumerable<System.Func<string, string>> packageNameOverrides, bool disallowUnsafeTypes) { } | ||
| public Hyperion.SerializerOptions WithDisallowUnsafeType(bool disallowUnsafeType) { } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.