Restored support of ISerialization #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvaluyskiy
commented
Mar 25, 2017
Hyperion.Tests/ISerializableTests.cs
Outdated
| } | ||
|
|
||
| [Fact(Skip="Not implemented yet")] | ||
| public void CanSerializeClassesWithISerializable() |
There was a problem hiding this comment.
This test is not working.
There was a problem hiding this comment.
@alexvaluyskiy What's the issue with it?
There was a problem hiding this comment.
I have created an issue #45
alexvaluyskiy
commented
Mar 27, 2017
| } | ||
|
|
||
| [Fact(Skip="Not implemented yet")] | ||
| public void ShouldNotThrowIfNoConstructorWithSerializationInfo() |
There was a problem hiding this comment.
I'm not sure, what should we do, if we can't find a proper constructor for ISerializable
#45
alexvaluyskiy
commented
Mar 27, 2017
| } | ||
|
|
||
| [Fact(Skip="Not implemented yet")] | ||
| public void SkipNonSerializedAttributeIfNoSerilizedAttribute() |
There was a problem hiding this comment.
NonSerializedAttribute should not work, if class if not marked with 'SerializableAttribute'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #42
And have added unit tests