Add lower bounds to SnapshotSelectionCriteria API Approval

akkadotnet · Jul 20, 2016 · e348f02 · e348f02
1 parent 4a95a1e
commit e348f02
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/src/core/Akka.API.Tests/CoreAPISpec.ApprovePersistence.approved.txt b/src/core/Akka.API.Tests/CoreAPISpec.ApprovePersistence.approved.txt
@@ -637,9 +637,11 @@ namespace Akka.Persistence
         public static readonly Akka.Persistence.SnapshotSelectionCriteria Latest;
         public readonly long MaxSequenceNr;
         public readonly System.DateTime MaxTimeStamp;
+        public readonly long MinSequenceNr;
+        public readonly System.Nullable<System.DateTime> MinTimestamp;
         public static readonly Akka.Persistence.SnapshotSelectionCriteria None;
         [Newtonsoft.Json.JsonConstructorAttribute()]
-        public SnapshotSelectionCriteria(long maxSequenceNr, System.DateTime maxTimeStamp) { }
+        public SnapshotSelectionCriteria(long maxSequenceNr, System.DateTime maxTimeStamp, long minSequenceNr = 0, System.Nullable<System.DateTime> minTimestamp = null) { }
         public SnapshotSelectionCriteria(long maxSequenceNr) { }
         public bool Equals(Akka.Persistence.SnapshotSelectionCriteria other) { }
         public override bool Equals(object obj) { }

diff --git a/src/core/Akka.Persistence/SnapshotProtocol.cs b/src/core/Akka.Persistence/SnapshotProtocol.cs
@@ -431,22 +431,22 @@ public SnapshotSelectionCriteria(long maxSequenceNr) : this(maxSequenceNr, DateT
         /// <summary>
         /// Upper bound for a selected snapshot's sequence number.
         /// </summary>
-        public long MaxSequenceNr { get; }
+        public readonly long MaxSequenceNr;
 
         /// <summary>
         /// Upper bound for a selected snapshot's timestamp.
         /// </summary>
-        public DateTime MaxTimeStamp { get; }
+        public readonly DateTime MaxTimeStamp;
 
         /// <summary>
         /// Lower bound for a selected snapshot's sequence number
         /// </summary>
-        public long MinSequenceNr { get; set; }
+        public readonly long MinSequenceNr;
 
         /// <summary>
         /// Lower bound for a selected snapshot's timestamp
         /// </summary>
-        public DateTime? MinTimestamp { get; set; }
+        public readonly DateTime? MinTimestamp;
 
         internal SnapshotSelectionCriteria Limit(long toSequenceNr)
         {