Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestKit] Modify ActorOfAsTestFSMRef to allow constructor arguments to underlying FSM<T,S> #1709

Closed
Aaronontheweb opened this issue Feb 16, 2016 · 1 comment · Fixed by #2451
Closed

[TestKit] Modify ActorOfAsTestFSMRef to allow constructor arguments to underlying FSM<T,S> #1709

Aaronontheweb opened this issue Feb 16, 2016 · 1 comment · Fixed by #2451
Labels
enhancement tests up for grabs

Comments

@Aaronontheweb
Copy link
Member

I'd be an improvement, I think to the ActorOfAsTestFSMRef method if we could pass in constructor arguments that will be used to construct the underlying FSM we're testing. Otherwise, having to rely on a parameterless FSM in order to test it this way eliminates a lot of valid design choices.
@Aaronontheweb
Copy link
Member Author

Relevant code: https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.TestKit/TestKitBase_ActorOf.cs#L236

Aaronontheweb added a commit to Aaronontheweb/akka.net that referenced this issue Jan 13, 2017
@Aaronontheweb
close akkadotnet#1709 verify that FSMs with constructor agruments can…
eb2428f 
… be instantiated
@Aaronontheweb Aaronontheweb mentioned this issue Jan 13, 2017
Merged
Danthar pushed a commit that referenced this issue Jan 16, 2017
@Aaronontheweb @Danthar
close #1709 verify that FSMs with constructor agruments can be instan…
cd1a851 
…tiated (#2451)

Merged. some perf tests are failing. But only by a very small margin. And would attribute those to build server busyness.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement tests up for grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

verify that FSMs with constructor agruments can be instantiated Aaronontheweb/akka.net
1 participant
@Aaronontheweb