Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BidiFlow.AtopMat method has wrong return type #3563

Closed
mayorovp opened this issue Aug 3, 2018 · 3 comments
Closed

BidiFlow.AtopMat method has wrong return type #3563

mayorovp opened this issue Aug 3, 2018 · 3 comments
Labels
akka-streams confirmed bug good for first-time contributors up for grabs
Milestone
1.3.10

Comments

@mayorovp
Copy link

mayorovp commented Aug 3, 2018 •
edited
Loading

version: current
platforms: all

https://github.com/akkadotnet/akka.net/blob/dev/src/core/Akka.Streams/Dsl/BidiFlow.cs#L281

Current signature:
BidiFlow<..., TMat> BidiFlow<..., TMat>.AtopMat(BidiFlow<..., TMat2>, Func<TMat, TMat2, TMat3> combine)

combine's result is TMat3, but it is used as TMat
@marcpiechura
Copy link
Contributor

@mayorovp good catch! Might want to fix it and send a PR?

mmisztal1980 added a commit to mmisztal1980/akka.net that referenced this issue Sep 13, 2018
@mmisztal1980
akkadotnet#3563 return type changed TMat -> TMat3
e3ec1f6
mmisztal1980 added a commit to mmisztal1980/akka.net that referenced this issue Sep 14, 2018
@mmisztal1980
akkadotnet#3563 Akka.Streams API signature modified
f23807f
@mmisztal1980 mmisztal1980 mentioned this issue Sep 14, 2018
Merged
Horusiath added a commit that referenced this issue Sep 15, 2018
@Horusiath
Merge pull request #3595 from mmisztal1980/bug/3563
0553c54 
#3563 AtopMat's return type changed TMat -> TMat3
@Aaronontheweb Aaronontheweb added this to the 1.3.10 milestone Sep 15, 2018
@mmisztal1980
Copy link
Contributor

Since the PR was merged, can the issue be closed?

@marcpiechura
Copy link
Contributor

@mmisztal1980 yup, thanks for the reminder.

Closed via #3595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
akka-streams confirmed bug good for first-time contributors up for grabs
Projects
None yet
Milestone
1.3.10
Development

No branches or pull requests
4 participants
@Aaronontheweb @mmisztal1980 @mayorovp @marcpiechura