Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatternMatch with result returning support. #1957

Merged
merged 3 commits into from
Jan 22, 2017

Conversation

kantora
Copy link
Contributor

@kantora kantora commented May 14, 2016

Especially useful for FSM state function definition.

@kantora kantora force-pushed the PatternMatchingWithReturn branch from 4531579 to edc65aa Compare May 18, 2016 06:34
@kantora
Copy link
Contributor Author

kantora commented May 18, 2016

Rebased on latest dev

@ismaelhamed
Copy link
Member

Any chance we can move this PR forward and have it merged?

@Danthar
Copy link
Member

Danthar commented Jan 16, 2017

Needs api approval. But other then that. Should be ok.

@Danthar
Copy link
Member

Danthar commented Jan 21, 2017

@kantora do you mind going through: http://getakka.net/docs/akka-developers/public-api-changes for this PR ?

@kantora
Copy link
Contributor Author

kantora commented Jan 22, 2017

@Danthar I don't mind, but I don't get at this moment what is expected to be done from me?
As far as I understood this API changes should be approved. Should I approve my own changes or this should be done by someone else?

@kantora
Copy link
Contributor Author

kantora commented Jan 22, 2017

Ouchh... finally got the main idea from second read.

@kantora
Copy link
Contributor Author

kantora commented Jan 22, 2017

Updated to the latest dev and added api approval.

@kantora
Copy link
Contributor Author

kantora commented Jan 22, 2017

But suppose this will become obsolete with C#7 built-in pattern matching.

@Aaronontheweb Aaronontheweb merged commit 0809eaa into akkadotnet:dev Jan 22, 2017
@Aaronontheweb Aaronontheweb added this to the 1.1.3 milestone Jan 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants