Mono compatibility verification #2311

Aaronontheweb · 2016-09-16T23:48:05Z

close #2254
close #2195
close #2194
close #1594
close #1110

Aaronontheweb · 2016-09-16T23:49:08Z

Going to turn on Mono CI after this is merged into dev, but you can see the results from the unsquashed version of this PR here: http://petabridge-ci.cloudapp.net/viewLog.html?buildId=15950&tab=buildResultsDiv&buildTypeId=AkkaNet_LinuxMonoBuild&guest=1

Aaronontheweb

I left actual // comments in most of the code where needed to explain the Mono-specific platform changes. Otherwise most of the code changes I made were fairly innocuous and better than what we had before, even for Windows-only.

Aaronontheweb · 2016-09-17T00:38:38Z

build.cmd

@@ -28,7 +28,7 @@ src\.nuget\NuGet.exe install FAKE -ConfigFile src\.nuget\Nuget.Config -OutputDir

 src\.nuget\NuGet.exe install NUnit.Console -ConfigFile src\.nuget\Nuget.Config -OutputDirectory src\packages\FAKE -ExcludeVersion -Version 3.2.1
 src\.nuget\NuGet.exe install xunit.runner.console -ConfigFile src\.nuget\Nuget.Config -OutputDirectory src\packages\FAKE -ExcludeVersion -Version 2.0.0
-src\.nuget\NuGet.exe install NBench.Runner -OutputDirectory src\packages -ExcludeVersion -Version 0.3.0
+src\.nuget\NuGet.exe install NBench.Runner -OutputDirectory src\packages -ExcludeVersion -Version 0.3.1


Mono-friendly implementation of NBench runner.

Aaronontheweb · 2016-09-17T00:39:14Z

build.fsx

+// Filter out assemblies which can't run on Linux, Mono, .NET Core, etc...
+
+open Fake.EnvironmentHelper
+let filterPlatformSpecificAssemblies (assembly:string) =


Platform-specific filter for specs inside FAKE. Allows us to run the same FAKE file for multiple platforms and skip tests that can't run due to environmental issues on a particular platform.

Eh, I'll leave it as-is for now in case someone wants a test that isn't just .Contains

Aaronontheweb · 2016-09-17T00:39:56Z

src/Akka.sln

@@ -152,7 +152,7 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.TestKit.Xunit", "contr
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "DependencyInjection", "DependencyInjection", "{B1D10183-8FAE-4506-B935-403FCED89BDB}"
 EndProject
-Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.DI.Core", "contrib\dependencyInjection\Akka.DI.Core\Akka.DI.Core.csproj", "{FDF09D18-B68E-4B95-B1F6-B89D9C6C3AE9}"
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Akka.DI.Core", "contrib\dependencyinjection\Akka.DI.Core\Akka.DI.Core.csproj", "{FDF09D18-B68E-4B95-B1F6-B89D9C6C3AE9}"


Had to fix capitalization of name or Linux builds fail.

Aaronontheweb · 2016-09-17T00:40:26Z

src/core/Akka.API.Tests/CoreAPISpec.ApproveCore.approved.txt

@@ -4929,6 +4929,10 @@ namespace Akka.Util
        public override bool IsRight { get; }
        public TB Value { get; }
    }
+    public class static RuntimeDetector


New class used to detect runtimes. Decided to unify all of our Mono detector implementations into a single static utility class.

Aaronontheweb · 2016-09-17T00:40:39Z

src/core/Akka.API.Tests/CoreAPISpec.ApproveRemote.approved.txt

@@ -1069,6 +1069,11 @@ namespace Akka.Remote
        void Remove(T resource);
        void Reset();
    }
+    public class static IpExtensions


Workarounds for IP mapping issues on Mono.

Should this really be a part of public API?

I can make it internal, since eventually we'll be able to do away with it.

Aaronontheweb · 2016-09-17T00:43:34Z

src/core/Akka.Remote/Transport/AkkaIO/AddressConverters.cs

@@ -21,7 +22,7 @@ public static Address ToAddress(this EndPoint endpoint, ActorSystem system)
                return new Address(AkkaIOTransport.Protocal, system.Name, dns.Host, dns.Port);
            var ip = endpoint as IPEndPoint;
            if (ip != null)
-                return new Address(AkkaIOTransport.Protocal, system.Name, ip.Address.MapToIPv4().ToString(), ip.Port);
+                return new Address(AkkaIOTransport.Protocal, system.Name, IpExtensions.MapToIPv4(ip.Address).ToString(), ip.Port);


Using our Mono-friendly IP mappers.

Aaronontheweb · 2016-09-17T00:43:59Z

src/core/Akka.Streams.Tests/Dsl/FlowAppendSpec.cs

@@ -19,7 +20,7 @@

 namespace Akka.Streams.Tests.Dsl
 {
-    public class FlowAppendSpec : AkkaSpec
+    public class FlowAppendSpec : Akka.TestKit.AkkaSpec


Fixed a compilation bug on Mono. Not sure why it was an issue to begin with.

Aaronontheweb · 2016-09-17T00:44:53Z

src/core/Akka/Actor/ActorRefProvider.cs

-                var props = Props.Create<GuardianActor>(UserGuardianSupervisorStrategy);
+            var cell = rootGuardian.Cell;
+            cell.ReserveChild(name);
+            var props = Props.Create<GuardianActor>(UserGuardianSupervisorStrategy);


The previous method we used here, which was a bit of a YAGNI thing to begin with, caused the mono runtime to randomly fail on some occasions due to an expression compiler bug.

Aaronontheweb · 2016-09-17T00:45:02Z

src/core/Akka/Actor/ActorRefProvider.cs

-            cell.InitChild(child);
-            child.Start();
-            return child;
+            var props = Props.Create(() => new SystemGuardianActor(userGuardian), _systemGuardianStrategy);


Same as above.

Aaronontheweb · 2016-09-17T00:46:02Z

src/core/Akka/Event/LoggingBus.cs

@@ -165,25 +166,27 @@ private void AddLogger(ActorSystemImpl system, Type loggerType, LogLevel logLeve
        {
            var loggerName = CreateLoggerName(loggerType);
            var logger = system.SystemActorOf(Props.Create(loggerType).WithDispatcher(system.Settings.LoggersDispatcher), loggerName);
-            var askTask = logger.Ask(new InitializeLogger(this));
+            var askTask = logger.Ask(new InitializeLogger(this), timeout);


If the logging system failed to start, the task we issued would never be de-allocated. This code has been corrected to align with the JVM.

Horusiath

In general everything is ok. Only one question to answer and one issue to be eventually created.

Horusiath · 2016-09-19T17:22:21Z

build.fsx

+// Filter out assemblies which can't run on Linux, Mono, .NET Core, etc...
+
+open Fake.EnvironmentHelper
+let filterPlatformSpecificAssemblies (assembly:string) =


Horusiath · 2016-09-19T17:23:55Z

src/core/Akka.API.Tests/CoreAPISpec.ApproveRemote.approved.txt

@@ -1069,6 +1069,11 @@ namespace Akka.Remote
        void Remove(T resource);
        void Reset();
    }
+    public class static IpExtensions


Should this really be a part of public API?

Horusiath · 2016-09-19T17:27:49Z

src/core/Akka.Streams.Tests/Dsl/FlowSelectAsyncSpec.cs

@@ -299,6 +300,9 @@ public void A_Flow_with_SelectAsync_must_handle_cancel_properly()
        [Fact]
        public void A_Flow_with_SelectAsync_must_not_run_more_futures_than_configured()
        {
+            if (IsMono) // TODO: 9/14/2016: Mono 4.4.2 blows up the XUnit test runner upon calling Thread.Interrupt below (@Aaronontheweb)


Is this issue noticed anywhere? If not, please create a ticket for it. This is not a good practice.

And createa ticket on the Mono repository

Pretty certain that this is an XUnit issue; it looks as though the Thread.Interrupt call interrupts the XUnit worker thread too.

xunit/xunit#979

Aaronontheweb · 2016-09-19T19:59:37Z

Updated everything in response to the feedback I received on the PR.

Aaronontheweb · 2016-09-19T20:00:09Z

Shit, forgot to update the approved API....

close akkadotnet#2254 close akkadotnet#2195 close akkadotnet#2194 close akkadotnet#1594 close akkadotnet#1110

Horusiath · 2016-09-19T22:25:46Z

You have my blessing to merge that.

Aaronontheweb added the needs review label Sep 16, 2016

Aaronontheweb force-pushed the mono-build-rebase branch 2 times, most recently from 45d53ba to 1083797 Compare September 17, 2016 00:36

Aaronontheweb commented Sep 17, 2016

View reviewed changes

Horusiath reviewed Sep 19, 2016

View reviewed changes

Aaronontheweb force-pushed the mono-build-rebase branch from 1083797 to ee02d4c Compare September 19, 2016 19:43

Mono compatibility verification.

dfcb4f7

close akkadotnet#2254 close akkadotnet#2195 close akkadotnet#2194 close akkadotnet#1594 close akkadotnet#1110

Aaronontheweb force-pushed the mono-build-rebase branch from ee02d4c to dfcb4f7 Compare September 19, 2016 20:03

marcpiechura merged commit 5b7bfcf into akkadotnet:dev Sep 20, 2016

Aaronontheweb removed the needs review label Sep 20, 2016

Aaronontheweb deleted the mono-build-rebase branch September 20, 2016 08:55

Aaronontheweb modified the milestone: 1.1.2 Sep 21, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mono compatibility verification #2311

Mono compatibility verification #2311

Aaronontheweb commented Sep 16, 2016

Aaronontheweb commented Sep 16, 2016

Aaronontheweb left a comment

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Horusiath Sep 19, 2016

Aaronontheweb Sep 19, 2016

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Horusiath Sep 19, 2016

Aaronontheweb Sep 19, 2016

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Aaronontheweb Sep 17, 2016

Horusiath left a comment

Horusiath Sep 19, 2016

Horusiath Sep 19, 2016

Horusiath Sep 19, 2016

alexvaluyskiy Sep 19, 2016

Aaronontheweb Sep 19, 2016

Aaronontheweb Sep 19, 2016

Aaronontheweb commented Sep 19, 2016

Aaronontheweb commented Sep 19, 2016

Horusiath commented Sep 19, 2016

Mono compatibility verification #2311

Mono compatibility verification #2311

Conversation

Aaronontheweb commented Sep 16, 2016

Aaronontheweb commented Sep 16, 2016

Aaronontheweb left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Horusiath left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aaronontheweb commented Sep 19, 2016

Aaronontheweb commented Sep 19, 2016

Horusiath commented Sep 19, 2016