Stream update 2.4.9 #2335
Merged
Stream update 2.4.9 #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcpiechura
force-pushed
the
stream_update_2.4.9
branch
from
d93c4e6 to
938ca19
Compare
push to a closed out
marcpiechura
force-pushed
the
stream_update_2.4.9
branch
from
b4dd375 to
e92e271
Compare
| @@ -15,7 +15,7 @@ namespace Akka.Streams.TestKit.Tests | |||
| { | |||
| public class TestPublisherSubscriberSpec : AkkaSpec | |||
| { | |||
| protected readonly ActorMaterializer Materializer; | |||
| private ActorMaterializer Materializer { get; } | |||
There was a problem hiding this comment.
why you need private property?
There was a problem hiding this comment.
For running this stream.
| @@ -30,7 +30,7 @@ public class InterpreterStressSpec : GraphInterpreterSpecKit | |||
| private readonly ITestOutputHelper _helper; | |||
|
|
|||
| // GraphStages can be reused | |||
| private static readonly Select<int,int> Select = new Select<int, int>(x=>x+1, Deciders.StoppingDecider); | |||
| private static readonly Select<int,int> Select = new Select<int, int>(x=>x+1); | |||
|
@alexvaluyskiy addressed your remarks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.