[WIP] fix static analized high priority issues #2391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxim-s
commented
Dec 1, 2016
| @@ -434,7 +434,7 @@ public override int GetHashCode() | |||
| { | |||
| int hashCode = (_node != null ? _node.GetHashCode() : 0); | |||
| hashCode = (hashCode * 397) ^ (_target != null ? _target.GetHashCode() : 0); | |||
| hashCode = (hashCode * 397) ^ (_direction != null ? _direction.GetHashCode() : 0); | |||
maxim-s
commented
Dec 1, 2016
| @@ -120,7 +120,7 @@ public void Enter(string name) | |||
| /// </summary> | |||
| public void Enter(TimeSpan timeout, ImmutableList<string> names) | |||
| { | |||
| _system.Log.Debug("entering barriers {0}", names.Aggregate((a,b) => a = ", " + b)); | |||
| _system.Log.Debug("entering barriers {0}", names.Aggregate((a, b) => "(" + a + "," + b + ")")); | |||
There was a problem hiding this comment.
'a' is always rewritten in method, and more clear debug message
maxim-s
commented
Dec 1, 2016
| @@ -730,7 +730,6 @@ protected void Accepting() | |||
| _endpoints.MarkAsQuarantined(gotuid.RemoteAddress, gotuid.Uid, | |||
| Deadline.Now + _settings.QuarantineDuration); | |||
| _eventPublisher.NotifyListeners(new QuarantinedEvent(gotuid.RemoteAddress, gotuid.Uid)); | |||
| Context.Stop(pass.Endpoint); | |||
There was a problem hiding this comment.
if policy is WasGated Context.Stop(pass.Endpoint) will cause null reference exception
https://github.com/akka/akka/blob/master/akka-remote/src/main/scala/akka/remote/Remoting.scala#L704
maxim-s
commented
Dec 1, 2016
| @@ -59,31 +59,29 @@ private void FaultRecreate(Exception cause) | |||
| if (System.Settings.DebugLifecycle) | |||
| Publish(new Debug(_self.Path.ToString(), failedActor.GetType(), "Restarting")); | |||
|
|
|||
| if (failedActor != null) | |||
There was a problem hiding this comment.
failedActor is _actor, _actor already checked on null
maxim-s
commented
Dec 1, 2016
| @@ -40,18 +40,9 @@ public static Task<T> Ask<T>(this ICanTell self, object message, TimeSpan? timeo | |||
| if (provider == null) | |||
| throw new ArgumentException("Unable to resolve the target Provider", nameof(self)); | |||
|
|
|||
| ResolveReplyTo(); | |||
There was a problem hiding this comment.
the same as do nothing
|
Neat. Nice work @maxim-s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all high priority issues here https://gist.github.com/maxim-s/41ef6139bebe0e728594f5ded28f2b58