Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api-docs] Various fixes #2487

Merged
merged 1 commit into from
Jan 31, 2017
Merged

Conversation

sean-gilliam
Copy link
Member

This PR contains various fixes including filling in TBD placeholders,
fixed numerous copyright headers and converted a repetitive class to a
T4 template.

@Danthar
Copy link
Member

Danthar commented Jan 30, 2017

public api has changed. Dont think that was intentional :P

@Aaronontheweb
Copy link
Member

@Danthar @sean-gilliam marking a method with an OSBSOLETE attribute can trigger a public API change, since attribute metadata does get factored into that.

btw, what are the T4 templates for?

@sean-gilliam
Copy link
Member Author

It was just for one class. There was a lot of classes with the same boilerplate and signatures like Class<T, T1>, Class <T, T1, T2>,Class<T, T1, T2, ...>. Just a lot of repetition. Changed it to make it easier to document.

The API change came in with one of that classes' methods. At the very end, it changes one of its parameters names. I fixed it to match the other method signatures. It's just a Utility class that user's prb wouldn't care about.

This PR contains various fixes including filling in TBD placeholders,
fixed numerous copyright headers and converted a repetitive class to a
T4 template.
@@ -4639,7 +4639,7 @@ namespace Akka.Tools.MatchHandler
public sealed class PartialHandlerArgumentsCapture<T, T1, T2, T3, T4, T5, T6, T7, T8, T9, T10, T11, T12, T13, T14, T15> : Akka.Tools.MatchHandler.IPartialHandlerArgumentsCapture<T>
{
public PartialHandlerArgumentsCapture() { }
public bool Handle(T message) { }
public bool Handle(T value) { }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Api change is just a name of the parameter, which shouldn't matter really.

@Aaronontheweb Aaronontheweb merged commit b0f114e into akkadotnet:dev Jan 31, 2017
@sean-gilliam sean-gilliam deleted the api-docs branch January 31, 2017 22:52
@Aaronontheweb Aaronontheweb modified the milestone: 1.1.4 Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants