squelched the Akka.Streams benchmarks with the highest flip rate #2506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed the past couple of months worth of data from TeamCity's Flaky Test Report, and opted to disable assertions for the Akka.Streams benchmarks with the highest flip rate. Some of these tests have a fail rate that's approaching ~50%, and I think it's because all of these specs work with the highest number of flows (import 1000 flows,etc...)
I'm proposing that we squelch them so CI fails less often. The cases these benchmarks are asserting are just the largest in the group (except for maybe
FusedGraphsBenchmark+RepeatTakeSelectAndAggregate
) and there are smaller versions of them all pass with no problem. Alternatively, we can just raise the ceiling on these assertions, since they assume that "if 10 X can be done in N milliseconds, then 100 X can be done in 10 * N milliseconds," which probably doesn't hold true in these cases.