[api-docs] More documentation #2577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// <returns>TBD</returns> | ||
| public Inlet<T1> In(int n) | ||
| { | ||
| if (n <= 0) throw new ArgumentException("n must be > 0", "n"); | ||
| if (n <= 0) throw new ArgumentOutOfRangeException(nameof(n), "n must be > 0"); |
There was a problem hiding this comment.
It is a big breaking change
There was a problem hiding this comment.
I'll revert those, but
- No one catches/processes Argument* type exceptions.
- None of our tests fail because of the change.
- It's the correct exception to throw.
This PR fleshes out more of the documentation labeled as TBD.
| @@ -791,6 +799,42 @@ public ProtocolStateActor(HandshakeInfo handshakeInfo, AssociationHandle wrapped | |||
| /// <param name="codec">TBD</param> | |||
| /// <param name="failureDetector">TBD</param> | |||
| /// <param name="refuseUid">TBD</param> | |||
| /// <exception cref="AkkaProtocolException"> | |||
There was a problem hiding this comment.
Dang @sean-gilliam, this is awesome!
There was a problem hiding this comment.
glad you like it. it was a pita keeping track of it all :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fleshes out more of the documentation labeled as TBD.