CommandAsync for persistent actors #2689

zbynek001 · 2017-05-21T13:31:07Z

Here is another try on CommandAsync topic.
I's introducing similar support for async/await as in ReceiveAsync.

Remarks:

As with ReceiveAsync, all other commands to actor are blocked until the command handler task finishes processing the current command, including the Persist and PersistAll callbacks.
It does NOT introduce async support for Persist callbacks, they work the same way as before

Horusiath · 2017-05-21T18:07:13Z

src/core/Akka.Persistence.Tests/PersistentActorSpecAsyncAwait.Actors.cs

+
+namespace Akka.Persistence.Tests
+{
+    //internal class BehaviorOneActor : PersistentActorSpec.ExamplePersistentActor


Why is this part commented?

I had to move it to another namespace. It inherits from PersistentActorSpec.ExamplePersistentActor but i need to use a different actor with the RunTask inside

Horusiath · 2017-05-21T18:09:23Z

src/core/Akka.API.Tests/CoreAPISpec.ApprovePersistence.approved.txt

@@ -243,6 +243,7 @@ namespace Akka.Persistence
        public void PersistAsync<TEvent>(TEvent @event, System.Action<TEvent> handler) { }
        protected abstract bool ReceiveCommand(object message);
        protected abstract bool ReceiveRecover(object message);
+        protected void RunTask(System.Func<System.Threading.Tasks.Task> action) { }


This method is not unique for the persistence. It should be either hidden or included in ActorBase class.

Actually it is unique to Eventsourced, because of the Persist callbacks.
Non-persistence actors already have other equivalents, e.g. UntypedActor have RunTask, ReceiveActor have ReceiveAsync

Horusiath · 2017-05-21T18:19:52Z

src/core/Akka.Persistence/Eventsourced.Recovery.cs

+                if (!t.IsCompleted)
+                {
+                    var tcs = new TaskCompletionSource<object>();
+                    t.ContinueWith(r =>


You probably won't need TaskCompletionSource here. ContinueWith will return continuation task, while TaskContinuationOption.NotOnFaulted | TaskContinuationOption.NotOnCancelled should allow you to get rid of forwarding cancelations and faults.

There's also one thing to remember - things like actor's Context or Self are fragile and won't work in task continuations. This also concerns all methods invoked here.

Before I didn't need it, but now i need to react also on failure.
Regarding Context, it works as usual. Context, Sender,.. are accessible inside the command handler. Same for Persist callback except of the Sender, but that's by design

Horusiath · 2017-05-21T18:23:24Z

src/core/Akka.Persistence.Tests/PersistentActorSpecAsyncAwait.Actors.cs

+                        Persist(new Evt(cmd.Data + "-0"), UpdateStateHandler);
+                        Context.Become(NewBehavior);
+                    });
+                    return true;


I don't think it's fully valid way of calling RunTask. As it won't be invoked immediately, the handler will return true, while the func inside may throw an exception. This may lead to a false positives, but I'd need to check how this would look like in other cases.

Should be the same behavior as with ReceiveAsync

Aaronontheweb · 2017-05-21T19:39:40Z

@zbynek001

ApprovalTests.Core.Exceptions.ApprovalMismatchException : Failed Approval: Received file D:\work\d26c9d7f36545acd\src\core\Akka.API.Tests\CoreAPISpec.ApprovePersistence.received.txt does not match approved file D:\work\d26c9d7f36545acd\src\core\Akka.API.Tests\CoreAPISpec.ApprovePersistence.approved.txt.
   at ApprovalTests.Approvers.FileApprover.Fail()
   at ApprovalTests.Core.Approver.Verify(IApprovalApprover approver, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalWriter writer, IApprovalNamer namer, IApprovalFailureReporter reporter)
   at ApprovalTests.Approvals.Verify(IApprovalWriter writer)
   at ApprovalTests.Approvals.Verify(String text)
   at Akka.API.Tests.CoreAPISpec.ApprovePersistence() in D:\work\d26c9d7f36545acd\src\core\Akka.API.Tests\CoreAPISpec.cs:line 53

Need to run the API approval process locally... http://getakka.net/docs/akka-developers/public-api-changes

zbynek001 · 2017-05-21T19:47:45Z

@Aaronontheweb will do that. Btw there is an issue with the approval ApiGenerator, the order of items is based on local culture, InvariantCulture might be better. Will create another pull request for that

Aaronontheweb · 2017-05-22T14:25:48Z

@zbynek001 rebasing on those changes since we merge in your API approval fix.

Danthar · 2017-08-04T09:45:14Z

Has some minor conflicts that need to be resolved. @Aaronontheweb we are not making this part of release 1.3 ?

Aaronontheweb · 2017-08-09T20:41:07Z

@Danthar yeah, this should definitely go into 1.3

Horusiath reviewed May 21, 2017

View reviewed changes

zbynek001 force-pushed the CommandAsync branch from 5b7b13d to e975083 Compare May 22, 2017 07:45

zbynek001 changed the title ~~[WIP] CommandAsync for persistent actors~~ CommandAsync for persistent actors May 22, 2017

alexvaluyskiy added the akka-persistence label Jun 11, 2017

zbynek001 force-pushed the CommandAsync branch from 4ebac2e to 7d505d8 Compare August 9, 2017 09:40

CommandAsync handling added to persistent actors

741453c

zbynek001 force-pushed the CommandAsync branch from 7d505d8 to 741453c Compare August 9, 2017 09:51

Danthar and others added 2 commits August 9, 2017 12:28

Merge branch 'v1.3' into CommandAsync

020ea0e

Merge branch 'v1.3' into CommandAsync

3bf1220

Aaronontheweb added this to the 1.3.0 milestone Aug 9, 2017

Merge branch 'v1.3' into CommandAsync

a258814

Aaronontheweb merged commit abf49d3 into akkadotnet:v1.3 Aug 9, 2017

zbynek001 deleted the CommandAsync branch June 24, 2018 12:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CommandAsync for persistent actors #2689

CommandAsync for persistent actors #2689

zbynek001 commented May 21, 2017 •

edited

Loading

Horusiath May 21, 2017

zbynek001 May 21, 2017

Horusiath May 21, 2017

zbynek001 May 21, 2017

Horusiath May 21, 2017

zbynek001 May 21, 2017

Horusiath May 21, 2017

zbynek001 May 21, 2017

Aaronontheweb commented May 21, 2017

zbynek001 commented May 21, 2017

Aaronontheweb commented May 22, 2017

Danthar commented Aug 4, 2017

Aaronontheweb commented Aug 9, 2017

CommandAsync for persistent actors #2689

CommandAsync for persistent actors #2689

Conversation

zbynek001 commented May 21, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aaronontheweb commented May 21, 2017

zbynek001 commented May 21, 2017

Aaronontheweb commented May 22, 2017

Danthar commented Aug 4, 2017

Aaronontheweb commented Aug 9, 2017

zbynek001 commented May 21, 2017 •

edited

Loading