sharding snapshot & journal cleanup #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek001
force-pushed
the
sharding-delete-messages-after-snapshot
branch
from
77aeb4a to
dc0d62c
Compare
zbynek001
changed the title
Horusiath
requested changes
May 26, 2017
| } | ||
| break; | ||
| case SaveSnapshotFailure m: | ||
| Log.Warning("PersistentShard snapshot failure: {}", m.Cause.Message); |
There was a problem hiding this comment.
In .NET logging we must provide index for arguments. So {} itself will fail, you need to use {0}, {1} and so on.
There was a problem hiding this comment.
Right, completely overlooked that. Fixed
zbynek001
force-pushed
the
sharding-delete-messages-after-snapshot
branch
from
dc0d62c to
96ff40c
Compare
Horusiath
approved these changes
May 26, 2017
Horusiath
added
addressed remarks
reviewed positively
and removed
reviewed with remarks
labels
| Log.Debug("PersistentShard snapshots matching {0} deleted successfully", m.Criteria); | ||
| break; | ||
| case DeleteSnapshotsFailure m: | ||
| Log.Warning("PersistentShard snapshots matching {0} deletion falure: {1}", m.Criteria, m.Cause.Message); |
|
@zbynek001 You have also implemented this issue |
|
I think that's obsolete code. |
zbynek001
force-pushed
the
sharding-delete-messages-after-snapshot
branch
from
96ff40c to
32deffd
Compare
Arkatufus
pushed a commit
to Arkatufus/akka.net
that referenced
this pull request
Jun 6, 2017
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of
akka/akka#21725
akka/akka#22916