[routing] Akka.Routing refactoring #2719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-gilliam
commented
Jun 1, 2017
| @@ -153,38 +153,28 @@ public override RouterConfig WithFallback(RouterConfig routerConfig) | |||
|
|
|||
| private RouterConfig OverrideUnsetConfig(RouterConfig other) | |||
| { | |||
| if (other is NoRouter) | |||
| if (other is Pool pool) | |||
There was a problem hiding this comment.
everything that isn't a Pool returned this , so this is the only real check we need. Same with the other routers.
sean-gilliam
commented
Jun 1, 2017
|
|
||
| if (_hashMapping(message) != null) | ||
| var hashMapping = _hashMapping(message); |
There was a problem hiding this comment.
This delegate was being called twice which should return the same value each time. So I stored it in a variable so it only needed to be called once.
sean-gilliam
force-pushed
the
routing_refactor
branch
from
64c8537 to
85335bf
Compare
This PR refactors the classes in the Akka.Routing namespace to take advantage of newer C# features. It also simplifies some of the logic in the various routers.
sean-gilliam
force-pushed
the
routing_refactor
branch
from
5c2b556 to
2b2ff41
Compare
|
looks great @sean-gilliam - love seeing the C#7 features cutting down on code bloat |
maxcherednik
reviewed
Jun 7, 2017
| switch (obj) | ||
| { | ||
| case null: | ||
| return new byte[] { 0 }; |
There was a problem hiding this comment.
I don't know the context, and how often this one called and maybe it's super micro, but seems like a constant?
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jun 28, 2017
This PR refactors the classes in the Akka.Routing namespace to take advantage of newer C# features. It also simplifies some of the logic in the various routers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the classes in the Akka.Routing namespace to take
advantage of newer C# features. It also simplifies some of the logic in
the various routers.