Enable Sqlite tests, uncommented snapshot tests in Persistence.Testkit #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexvaluyskiy snapshot specs are failing on mono |
marcpiechura
approved these changes
Jun 4, 2017
| @@ -14,7 +14,8 @@ | |||
|
|
|||
| namespace Akka.Persistence.TestKit.Tests | |||
| { | |||
| public class LocalSnapshotStoreSpec : SnapshotStoreSpec | |||
| // FIXME | |||
| public abstract class LocalSnapshotStoreSpec : SnapshotStoreSpec | |||
There was a problem hiding this comment.
What's the reason to make it abstract?
There was a problem hiding this comment.
To skip only LocalSnapshot spec, not all specs inherited from SnapshotStoreSpec
|
@alexvaluyskiy now all sqlite specs failed on windows |
|
@alexvaluyskiy @Silv3rcircl3 that might be because the |
alexvaluyskiy
force-pushed
the
coreclr_fix_persistencetests
branch
from
98b1f14 to
fe4cd7f
Compare
alexvaluyskiy
commented
Jun 6, 2017
| @@ -4,7 +4,7 @@ | |||
| <PropertyGroup> | |||
| <AssemblyTitle>Akka.Persistence.Sqlite.Tests</AssemblyTitle> | |||
| <TargetFrameworks>net452;netcoreapp1.1</TargetFrameworks> | |||
| <RuntimeIdentifier>win7-x64</RuntimeIdentifier> | |||
| <RuntimeIdentifier Condition=" '$(TargetFramework)' == 'net452' And '$(OS)' == 'Windows_NT'">win7-x64</RuntimeIdentifier> | |||
There was a problem hiding this comment.
Looks good to me in the short-run - I @heynickc was mentioning this morning that the runtime might be part of the reason why we're having some trouble with the tests...
Aaronontheweb
pushed a commit
to Aaronontheweb/akka.net
that referenced
this pull request
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #2659