Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet packaging for MNTR (Windows/.NET 4.5.2) #2935

Merged
merged 12 commits into from
Aug 9, 2017
Merged

NuGet packaging for MNTR (Windows/.NET 4.5.2) #2935

merged 12 commits into from
Aug 9, 2017

Conversation

heynickc
Copy link
Contributor

@heynickc heynickc commented Aug 4, 2017

Initial work to get MNTR Test Runner .NET 4.5.2/win7-64x packaged using dotnet pack. Requires the use of a custom .nuspec files so metadata is hard-coded into it right now. This is just to get a working package ready for release, although later we should work on substituting metadata into the .nuspec.

Using dotnet-pack simply on the .csproj file only outputs the .exe into the lib/net452 folder, without dependent dlls. This is why I had to use a .nuspec file to include all dependencies in the .nupkg.

Will use the same build step to output the netcoreapp1.1 version of the runner.

@Aaronontheweb
Copy link
Member

@Arkatufus @heynickc houston we have a problem

[22:38:45]	[MultiNodeTests] 
[22:38:45]	[MultiNodeTests] 
[22:38:45]	[MultiNodeTests] 
[22:38:45]	[MultiNodeTests] 
[22:38:45]	[MultiNodeTests] Unhandled Exception: Unhandled Exception: Unhandled Exception: 
[22:38:45]	[MultiNodeTests] 
[22:38:45]	[MultiNodeTests] Unhandled Exception: Unhandled Exception: 
[22:38:46]	[MultiNodeTests] Unhandled Exception: Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:46]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:46]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:46]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:46]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:46]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:46]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:46]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:46]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:46]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:46]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:50]	[MultiNodeTests] 
[22:38:51]	[MultiNodeTests] Unhandled Exception: 
[22:38:51]	[MultiNodeTests] 
[22:38:51]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:51]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:51]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:51]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:51]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:51]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:51]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:51]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:51]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:51]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:51]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:51]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:51]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:51]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:51]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:51]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:51]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:51]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:54]	[MultiNodeTests] 
[22:38:54]	[MultiNodeTests] Unhandled Exception: 
[22:38:54]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:54]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:54]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:54]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:54]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:54]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:54]	[MultiNodeTests] Unhandled Exception: 
[22:38:54]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:54]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:54]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:54]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:54]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:54]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:54]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:54]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:54]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:54]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:54]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:54]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:57]	[MultiNodeTests] 
[22:38:57]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:57]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:57]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:57]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:57]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:57]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:57]	[MultiNodeTests] 
[22:38:57]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:57]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:57]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:57]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:57]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:57]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:38:57]	[MultiNodeTests] 
[22:38:57]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:38:57]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:38:57]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:38:57]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:38:57]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:38:57]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:00]	[MultiNodeTests] 
[22:39:00]	[MultiNodeTests] 
[22:39:00]	[MultiNodeTests] 
[22:39:00]	[MultiNodeTests] Unhandled Exception: 
[22:39:00]	[MultiNodeTests] Unhandled Exception: Unhandled Exception: Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:00]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:00]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:00]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:00]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:00]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:00]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:00]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:00]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:00]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:00]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:00]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:01]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:01]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:01]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:01]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:01]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:01]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:01]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:01]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:01]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:01]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:01]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:01]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:04]	[MultiNodeTests] 
[22:39:04]	[MultiNodeTests] 
[22:39:04]	[MultiNodeTests] Unhandled Exception: Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:04]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:04]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:04]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:04]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:04]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:04]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:04]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:04]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:04]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:04]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:04]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:07]	[MultiNodeTests] 
[22:39:07]	[MultiNodeTests] 
[22:39:07]	[MultiNodeTests] Unhandled Exception: 
[22:39:07]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:07]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:07]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:07]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:07]	[MultiNodeTests] 
[22:39:07]	[MultiNodeTests] Unhandled Exception: Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:07]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:07]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:07]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:07]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:07]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:07]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:07]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:07]	[MultiNodeTests] System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:07]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:07]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:07]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:07]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:10]	[MultiNodeTests] 
[22:39:10]	[MultiNodeTests] Unhandled Exception: System.ArgumentException: Item has already been added. Key in dictionary: 'multinode.test-assembly'  Key being added: 'multinode.test-assembly'
[22:39:10]	[MultiNodeTests]    at System.Collections.Hashtable.Insert(Object key, Object nvalue, Boolean add)
[22:39:10]	[MultiNodeTests]    at Akka.Remote.TestKit.CommandLine.<>c.<.cctor>b__6_0()
[22:39:10]	[MultiNodeTests]    at System.Lazy`1.CreateValue()
[22:39:10]	[MultiNodeTests]    at System.Lazy`1.LazyInitValue()
[22:39:10]	[MultiNodeTests]    at Akka.NodeTestRunner.Program.Main(String[] args)
[22:39:10]	[MultiNodeTests] 
[22:39:10]	[MultiNodeTests] 

From the build log

@Arkatufus
Copy link
Contributor

Arkatufus commented Aug 5, 2017

Should be fixed in #2936

Aaronontheweb and others added 5 commits August 5, 2017 15:47
* v1.3:
  Fix MNTR failed to run (#2936)
  fix deserialization
  fixed API
  fix
  Updated Exceptions serializer
  Uncommented Remoting Routers test
  Added exception serialization
  Add cross-platform spec test to MNTR (#2919)
  Hyperion.Serialization to target netstandard1.6 (#2929)
@heynickc
Copy link
Contributor Author

heynickc commented Aug 7, 2017

This PR now includes publishing the .NET Core version as well

@heynickc heynickc changed the title NuGet packaging for MNTR (Windows/.NET 4.5.2) WIP NuGet packaging for MNTR (Windows/.NET 4.5.2) Aug 8, 2017
@heynickc
Copy link
Contributor Author

heynickc commented Aug 8, 2017

Changed to WIP temporarily as we're going to replace some output-folder locations to use the output of dotnet-publish for the standalone .NET Core runner

@heynickc heynickc changed the title WIP NuGet packaging for MNTR (Windows/.NET 4.5.2) NuGet packaging for MNTR (Windows/.NET 4.5.2) Aug 9, 2017
@heynickc
Copy link
Contributor Author

heynickc commented Aug 9, 2017

This will be ready for merge after CI passes

@heynickc
Copy link
Contributor Author

heynickc commented Aug 9, 2017

Also removing multi feature added by @Arkatufus here due to the inability to guarantee x-plat compatibility due to issues with serialization between netcoreapp1.1 and net45

@Arkatufus Arkatufus merged commit 500cd3a into akkadotnet:v1.3 Aug 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants