-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Member status: Weakly up #3099
Merged
Merged
Member status: Weakly up #3099
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f1d4f60
cluster member status (weakly-up): initial commit
Horusiath a4dd8bb
regenerated protobuf cluster messages
Horusiath d8ba52a
cluster approvals API for weakly up status
Horusiath 0b65e11
fixed WeaklyUp specs
Horusiath edc75aa
turned off weakly-up in necessary specs
Horusiath d355934
turned weakly-up = off by default
Horusiath 6f152cc
Merge branch 'dev' into weakly-up
Aaronontheweb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
161 changes: 161 additions & 0 deletions
161
src/core/Akka.Cluster.Tests.MultiNode/MemberWeaklyUpSpec.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,161 @@ | ||
| //----------------------------------------------------------------------- | ||
| // <copyright file="MemberWeaklyUpSpec.cs" company="Akka.NET Project"> | ||
| // Copyright (C) 2009-2016 Lightbend Inc. <http://www.lightbend.com> | ||
| // Copyright (C) 2013-2016 Akka.NET project <https://github.com/akkadotnet/akka.net> | ||
| // </copyright> | ||
| //----------------------------------------------------------------------- | ||
|
|
||
| using System; | ||
| using System.Collections.Immutable; | ||
| using System.Linq; | ||
| using Akka.Cluster.TestKit; | ||
| using Akka.Configuration; | ||
| using Akka.Remote.TestKit; | ||
| using Akka.Remote.Transport; | ||
| using Akka.TestKit; | ||
|
|
||
| namespace Akka.Cluster.Tests.MultiNode | ||
| { | ||
| public class MemberWeaklyUpConfig : MultiNodeConfig | ||
| { | ||
| public RoleName First { get; } | ||
| public RoleName Second { get; } | ||
| public RoleName Third { get; } | ||
| public RoleName Fourth { get; } | ||
| public RoleName Fifth { get; } | ||
|
|
||
| public MemberWeaklyUpConfig() | ||
| { | ||
| First = Role("first"); | ||
| Second = Role("second"); | ||
| Third = Role("third"); | ||
| Fourth = Role("fourth"); | ||
| Fifth = Role("fifth"); | ||
|
|
||
| CommonConfig = DebugConfig(on: false) | ||
| .WithFallback(ConfigurationFactory.ParseString(@" | ||
| akka.remote.retry-gate-closed-for = 3s | ||
| akka.cluster.allow-weakly-up-members = on")) | ||
| .WithFallback(MultiNodeClusterSpec.ClusterConfig()); | ||
|
|
||
| TestTransport = true; | ||
| } | ||
| } | ||
|
|
||
| public class MemberWeaklyUpSpec : MultiNodeClusterSpec | ||
| { | ||
| private readonly MemberWeaklyUpConfig _config; | ||
| private readonly ImmutableArray<RoleName> _side1; | ||
| private readonly ImmutableArray<RoleName> _side2; | ||
|
|
||
| public MemberWeaklyUpSpec() : this(new MemberWeaklyUpConfig()) | ||
| { | ||
| } | ||
|
|
||
| private MemberWeaklyUpSpec(MemberWeaklyUpConfig config) : base(config, typeof(MemberWeaklyUpSpec)) | ||
| { | ||
| _config = config; | ||
| _side1 = ImmutableArray.CreateRange(new[] { config.First, config.Second }); | ||
| _side2 = ImmutableArray.CreateRange(new[] { config.Third, config.Fourth, config.Fifth }); | ||
| MuteMarkingAsUnreachable(); | ||
| } | ||
|
|
||
| [MultiNodeFact] | ||
| public void Spec() | ||
| { | ||
| A_cluster_of_3_members_should_reach_initial_convergence(); | ||
| A_cluster_of_3_members_should_detect_network_partition_and_mark_nodes_on_the_other_side_as_unreachable(); | ||
| A_cluster_of_3_members_should_accept_joining_on_each_side_and_set_status_to_WeaklyUp(); | ||
| A_cluster_of_3_members_should_change_status_to_Up_after_healed_network_partition(); | ||
| } | ||
|
|
||
| public void A_cluster_of_3_members_should_reach_initial_convergence() | ||
| { | ||
| AwaitClusterUp(_config.First, _config.Third, _config.Fourth); | ||
| EnterBarrier("after-1"); | ||
| } | ||
|
|
||
| public void A_cluster_of_3_members_should_detect_network_partition_and_mark_nodes_on_the_other_side_as_unreachable() | ||
| { | ||
| Within(TimeSpan.FromSeconds(20), () => | ||
| { | ||
| RunOn(() => | ||
| { | ||
| // split the cluster in two parts (first, second) / (third, fourth, fifth) | ||
| foreach (var role1 in _side1) | ||
| foreach (var role2 in _side2) | ||
| TestConductor.Blackhole(role1, role2, ThrottleTransportAdapter.Direction.Both).Wait(TimeSpan.FromSeconds(3)); | ||
| }, _config.First); | ||
|
|
||
| EnterBarrier("after-split"); | ||
|
|
||
| RunOn(() => | ||
| { | ||
| AwaitAssert(() => | ||
| ClusterView.UnreachableMembers | ||
| .Select(m => m.Address).ToImmutableHashSet() | ||
| .ShouldBe(ImmutableHashSet.CreateRange(new[] { GetAddress(_config.Third), GetAddress(_config.Fourth) }))); | ||
| }, _config.First); | ||
|
|
||
| RunOn(() => | ||
| { | ||
| AwaitAssert(() => | ||
| ClusterView.UnreachableMembers | ||
| .Select(m => m.Address).ToImmutableHashSet() | ||
| .ShouldBe(ImmutableHashSet.CreateRange(new[] { GetAddress(_config.First) }))); | ||
| }, _config.Third, _config.Fourth); | ||
|
|
||
| EnterBarrier("after-2"); | ||
| }); | ||
| } | ||
|
|
||
| public void A_cluster_of_3_members_should_accept_joining_on_each_side_and_set_status_to_WeaklyUp() | ||
| { | ||
| Within(TimeSpan.FromSeconds(20), () => | ||
| { | ||
| RunOn(() => Cluster.Get(Sys).Join(GetAddress(_config.First)), _config.Second); | ||
| RunOn(() => Cluster.Get(Sys).Join(GetAddress(_config.Fourth)), _config.Fifth); | ||
|
|
||
| EnterBarrier("joined"); | ||
|
|
||
| RunOn(() => AwaitAssert(() => | ||
| { | ||
| ClusterView.Members.Count.ShouldBe(4); | ||
| ClusterView.Members.Any(m => m.Address == GetAddress(_config.Second) && m.Status == MemberStatus.WeaklyUp).ShouldBe(true); | ||
|
|
||
| }), _side1.ToArray()); | ||
|
|
||
| RunOn(() => AwaitAssert(() => | ||
| { | ||
| ClusterView.Members.Count.ShouldBe(4); | ||
| ClusterView.Members.Any(m => m.Address == GetAddress(_config.Fifth) && m.Status == MemberStatus.WeaklyUp).ShouldBe(true); | ||
|
|
||
| }), _side2.ToArray()); | ||
|
|
||
| EnterBarrier("after-3"); | ||
| }); | ||
| } | ||
|
|
||
| public void A_cluster_of_3_members_should_change_status_to_Up_after_healed_network_partition() | ||
| { | ||
| Within(TimeSpan.FromSeconds(20), () => | ||
| { | ||
| RunOn(() => | ||
| { | ||
| foreach (var role1 in _side1) | ||
| foreach (var role2 in _side2) | ||
| { | ||
| TestConductor.PassThrough(role1, role2, ThrottleTransportAdapter.Direction.Both).Wait(TimeSpan.FromSeconds(3)); | ||
| } | ||
| }, _config.First); | ||
|
|
||
| EnterBarrier("after-passThrough"); | ||
|
|
||
| AwaitAllReachable(); | ||
| AwaitMembersUp(5); | ||
|
|
||
| EnterBarrier("after-4"); | ||
| }); | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Son of a bitch... I totally missed this when I originally reviewed the PR. It's going to great the same problems here that happened in #2584. This is a bug. I'll PR it per #3274