Fixed Akka.Cluster.TestKit nuget package (Fixes #3131) #3139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a.Tests.Shared.Internals, which is not public. Replaced usages of "Should" extension assertions with ITestKitAssertions as to not require Akka.Tests.Shared.Internals.
|
This can be considered a breaking change since Akka.Cluster.TestKit version 1.2.3 and earlier was exposing the AkkaSpecExtensions class because it was a public linked file. Not sure if that was intentional or not. |
|
@derrickcrowne thanks! No, this was not an intentional breaking change. An oversight on our part mostly due to the change in MSBUILD15 and how we handled linked files. |
Aaronontheweb
approved these changes
Oct 3, 2017
| }); | ||
| AwaitAssert(() => ClusterView.Members.Count.ShouldBe(numbersOfMembers)); | ||
| AwaitAssert(() => ClusterView.Members.All(m => m.Status == MemberStatus.Up).ShouldBeTrue("All members should be up")); | ||
| AwaitAssert(() => _assertions.AssertEqual(numbersOfMembers, ClusterView.Members.Count)); |
There was a problem hiding this comment.
Please add the "All members should be up" error message back here.
There was a problem hiding this comment.
Ah whoops, nevermind. It's there on the line below.
|
Closes #3131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Akka.Cluster.TestKit's dependency on Akka.Test.Shared.Internals which is not on nuget (and according to it's readme not intended to be public).
Replaced the usages of "Should" extension assertions with ITestKitAssertions as they were used elsewhere in the file, and the Shared.Internals extensions weren't really providing that much value.