Update DeviceGroupQuery.cs #3221
Conversation
Fixed timing of the first change of behaviour, moved from OnReceive to Constructor method
|
Thanks @nsanitate ! |
|
@Aaronontheweb you can try the patch cloning https://github.com/nsanitate/iot-app and starting tests. If you follow the tutorial changing behaviour in OnResolve method instead of in Constructor, all tests in DeviceGroupQueryTest class will fail. |
| @@ -26,6 +27,8 @@ public DeviceGroupQuery(Dictionary<IActorRef, string> actorToDeviceId, long requ | |||
| Timeout = timeout; | |||
|
|
|||
| queryTimeoutTimer = Context.System.Scheduler.ScheduleTellOnceCancelable(timeout, Self, CollectionTimeout.Instance, Self); | |||
|
|
|||
| Become(WaitingForReplies(new Dictionary<string, ITemperatureReading>(), new HashSet<IActorRef>(ActorToDeviceId.Keys))); | |||
There was a problem hiding this comment.
You can just change this to WaitingForReplies without the Become syntax here
There was a problem hiding this comment.
The output of WaitingForReplies is a factory method that will be used as input of Context.Become method. The author use it in the same way at row 116.
| #region query-state | ||
| protected override void OnReceive(object message) | ||
| { | ||
| Become(WaitingForReplies(new Dictionary<string, ITemperatureReading>(), new HashSet<IActorRef>(ActorToDeviceId.Keys))); |
There was a problem hiding this comment.
Yeah, this is wrong. Good catch.
| #endregion | ||
| #endregion | ||
|
|
||
| protected override void OnReceive(object message) |
There was a problem hiding this comment.
We should probably just refactor this actor to do all of its actual message handling inside OnReceive instead of having this behavior-switching. We could just make the state private members. Although this is a cool way of showing how you can use closures to build receive methods, which is a valid technique in practice.
There was a problem hiding this comment.
I think the purpose of this tutorial was to teach using the Context.Become() trick instead of just making the repliesSoFar and stillWaiting structures mutable fields of the actor
There was a problem hiding this comment.
Got it. In that case, we should leave it as-is. Want to teach the concept.
|
@nsanitate what do you think of my comments? |
Fixed exit condition check on stillWaiting instead of repliesSoFar
Fixed timing of the first change of behaviour, moved from OnReceive to Constructor method