Retry stage #3235
Merged
Retry stage #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Horusiath
reviewed
Jan 1, 2018
src/core/Akka.Streams/Dsl/Retry.cs
Outdated
| /// <typeparam name="TO">output elements type</typeparam> | ||
| /// <typeparam name="TM">materialized value type</typeparam> | ||
| [ApiMayChange] | ||
| public static IGraph<FlowShape<Tuple<TI, TS>, Tuple<Result<TO>, TS>>, TM> Create<TI, TS, TO, TM>( |
There was a problem hiding this comment.
I know that his signature is quite long, but maybe we should stick to convention for generic type parameters (TIn, TState, TOut, TMat)?
Horusiath
approved these changes
Jan 1, 2018
|
@marcpiechura looks like we have a conflict in the |
|
fixed conflicts |
|
@marcpiechura have hard failures on all of the framing specs now. Definitely something wrong there. |
src/core/Akka.Streams/Dsl/Framing.cs
Outdated
|
|
||
| private readonly Outlet<ByteString> _out = new Outlet<ByteString>("DelimiterFraming.in"); | ||
|
|
||
| public override FlowShape<ByteString, ByteString> Shape { get; } |
There was a problem hiding this comment.
Not sure why I added those properties since they're already provided by the base class...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.