Unit test Akka.FSharp.System.create with extensions #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen creating with a configuration that has akka.extensions specified.
…hen creating with a configuration that has akka.extensions specified.
|
I did a little research, and there is a conflicting serializer ID. Both the Cluster Tools DistributedPubSubMessageSerializer and the FSharp ExprSerializer use the same identifier, 9. I think changing the ID for one of these serializers would fix this unit test. There should probably be a unit test to verify that all built-in serializers can be loaded togehter (i.e. they have unique IDs). |
|
Thx for your contribution |
|
@AaronEshbach did that issue with the colliding serializer IDs get resolved? Or should we file a new issue for that? |
This was referenced Jun 4, 2018
|
We tested Akka.FSharp with Akka.Cluster.Tools at version 1.3.8, and the issue appears to be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test to demonstrate a bug with Akka.FSharp.System.create when creating with a configuration that has akka.extensions specified.