Akka.Remote memory leak fix: use singleton allocators for DotNetty channels. #3436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aaronontheweb
commented
May 5, 2018
| .Option(ChannelOption.SoReuseaddr, Settings.TcpReuseAddr) | ||
| .Option(ChannelOption.SoKeepalive, Settings.TcpKeepAlive) | ||
| .Option(ChannelOption.TcpNodelay, Settings.TcpNoDelay) | ||
| .Option(ChannelOption.AutoRead, false) | ||
| .Option(ChannelOption.SoBacklog, Settings.Backlog) | ||
| .Option(ChannelOption.Allocator, Settings.EnableBufferPooling ? (IByteBufferAllocator)new PooledByteBufferAllocator() : new UnpooledByteBufferAllocator()) | ||
| .Option(ChannelOption.Allocator, Settings.EnableBufferPooling ? (IByteBufferAllocator)PooledByteBufferAllocator.Default : UnpooledByteBufferAllocator.Default) |
There was a problem hiding this comment.
This would definitely solve the allocator issue for clients... but the server is where we detected this memory leak and IIRC, this ServerBootstrap gets re-used to recreate client connections over and over again. Thus, I'm not sure this would actually impact the server. Bleh.
|
Got approval from @Horusiath in Gitter, so I think we're good to go here. Can get this in the next nightly for users experiencing #3430 |
This was referenced May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3430
So this was a bug I introduced in #3395
When manually configuring the allocator for use inside the
DotNettyTransport, I wasnew-ing up an allocator each time. Instead going forward we'll use the singleton default built into DotNetty.I'm not 100% sure this eliminates any possibility of buffers leaking on all platforms, since it seems like there's some major runtime differences that could affect this on .NET Core vs. .NET and on Linux / Windows, but this is definitely one possible source of the problem.