Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run NBench test despite previous failed #3443

Merged

Conversation

alex-bogomaz
Copy link
Contributor

Hello, please review this PR
it fixes #3268 - now build process runs all NBench test assemblies, even if some of them are failed.

In case of error it produces following sample output -
here we have 2 fails:

  • one when runner exited with -1
  • another when runner timed-out:
Running build failed.
Error:
System.Exception: NBench.Runner failed for 2 run(s):
1: "System.Exception: D:\GitHub\alex-bogomaz\akka.net\tools\NBench.Runner\lib\net45\NBench.Runner.exe "D:\GitHub\alex-bogomaz\akka.net
\src\core\Akka.Cluster.Tests.Performance\bin\Release\net452\Akka.Cluster.Tests.Performance.dll" "output-directory="D:\GitHub\alex-bogo
maz\akka.net\PerfResults"" "concurrent="true"" "trace="true"" "teamcity="false""
exited with code -1
   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1379.Invoke(String message)
   at FSI_0005.Build.failedRuns@289-6.Invoke(String asm)"

2: "System.Exception: Process D:\GitHub\alex-bogomaz\akka.net\tools\NBench.Runner\lib\net45\NBench.Runner.exe "D:\GitHub\alex-bogomaz\
akka.net\src\core\Akka.Remote.Tests.Performance\bin\Release\net452\Akka.Remote.Tests.Performance.dll" "output-directory="D:\GitHub\ale
x-bogomaz\akka.net\PerfResults"" "concurrent="true"" "trace="true"" "teamcity="false""  timed out.
   at Fake.ProcessHelper.ExecProcessWithLambdas@116-22.Invoke(String message) in D:\code\fake\src\app\FakeLib\ProcessHelper.fs:line 11
6
   at Fake.ProcessHelper.ExecProcessWithLambdas(FSharpFunc`2 configProcessStartInfoF, TimeSpan timeOut, Boolean silent, FSharpFunc`2 e
rrorF, FSharpFunc`2 messageF) in D:\code\fake\src\app\FakeLib\ProcessHelper.fs:line 116
   at FSI_0005.Build.runNBench@262.Invoke(String assembly)
   at FSI_0005.Build.failedRuns@289-6.Invoke(String asm)"


   at Microsoft.FSharp.Core.PrintfModule.PrintFormatToStringThenFail@1379.Invoke(String message)
   at Fake.TargetHelper.runSingleTarget(TargetTemplate`1 target) in D:\code\fake\src\app\FakeLib\TargetHelper.fs:line 626

@Aaronontheweb
Copy link
Member

@alex-bogomaz dude, you are the man. Thank you! One less build script thing I have to fix myself. I appreciate this very much.

@Aaronontheweb Aaronontheweb merged commit f6bc729 into akkadotnet:dev May 10, 2018
@Aaronontheweb Aaronontheweb modified the milestone: 1.3.7 May 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FAKE discontinues execution of subsequent performance test libraries upon encountering exception
2 participants